chrome/browser/ui/toolbar/wrench_menu_model.cc - Issue 1228223002: Close wrench menu when Media Router Action clicked in Views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model.cc

Issue 1228223002: Close wrench menu when Media Router Action clicked in Views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per rdevlin.cronin@'s comments and rebase. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/toolbar/media_router_action_platform_delegate.h ('K') | « chrome/browser/ui/toolbar/toolbar_actions_bar.cc ('k') | chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc » ('j') | chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/wrench_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/wrench_menu_model.cc b/chrome/browser/ui/toolbar/wrench_menu_model.cc

index 3912f73c089d161ad55eacc61a8e27790dc41236..62a15b212a4e983e52830371b830f8e5c8a5c59d 100644

--- a/chrome/browser/ui/toolbar/wrench_menu_model.cc

+++ b/chrome/browser/ui/toolbar/wrench_menu_model.cc

@@ -1037,7 +1037,7 @@ void WrenchMenuModel::CreateExtensionToolbarOverflowMenu() {

if (!extensions::ExtensionToolbarModel::Get(browser_->profile())->

all_icons_visible() ||

ComponentToolbarActionsFactory::GetInstance()->

- GetNumComponentActions() > 0) {

+ GetNumComponentActions(browser_) > 0) {

#if defined(OS_MACOSX)

// There's a bug in AppKit menus, where if a menu item with a custom view

// (like the extensions overflow menu) is the first menu item, it is not