Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 12282019: Disable "using base::FilePath" on Linux since it now compiles. (Closed)

Created:
7 years, 10 months ago by brettw
Modified:
7 years, 10 months ago
CC:
chromium-reviews, grt+watch_chromium.org, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, darin-cc_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Disable "using base::FilePath" on Linux since it now compiles. This keeps the using for other platforms temporarily. This patch is to "stop the bleeding" since new conflicts are added every day. The other platforms will be fixed in followup patches. This also adds an exception for the MTPD code which has a circular dependency on FilePath. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183043

Patch Set 1 #

Patch Set 2 : git log #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -69 lines) Patch
M base/base_paths_mac.mm View 3 chunks +6 lines, -6 lines 0 comments Download
M base/file_path.h View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M base/file_util_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_mac.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M base/file_version_info_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/file_util_icu_unittest.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M base/native_library_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/process_linux.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_scheduler_unittest.cc View 1 2 4 chunks +16 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 2 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/installer/util/create_reg_key_work_item.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/installer/util/google_update_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/helper.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/installer/util/installation_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/installer_state.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/installer/util/logging_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 1 2 7 chunks +10 lines, -7 lines 0 comments Download
M chromeos/network/onc/onc_test_utils.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/tools/onc_validator/onc_validator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/socket/tcp_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
brettw
7 years, 10 months ago (2013-02-17 19:34:18 UTC) #1
TBR=jar

Powered by Google App Engine
This is Rietveld 408576698