Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: base/file_path.h

Issue 12282019: Disable "using base::FilePath" on Linux since it now compiles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base_paths_mac.mm ('k') | base/file_util_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_path.h
diff --git a/base/file_path.h b/base/file_path.h
index e5c4b846f1c37fd61c95c9e7a202aa734df1e75e..c01da94026801a57a6933081e06b3c389ec3240d 100644
--- a/base/file_path.h
+++ b/base/file_path.h
@@ -402,8 +402,15 @@ class BASE_EXPORT FilePath {
} // namespace base
-// TODO(brettw) remove this once callers properly use the base namespace.
+// Temporarily have non-Linux platforms use a "using" so we can convert those
+// over one-at-a-time.
+//
+// http://crosbug.com/39008 MTPD has a circular dependency on base and uses the
+// old non-namespaced FilePath.
+#if defined(MTPD_DEVICE_MANAGER_H_) || defined(OS_CHROMEOS) || \
+ !defined(OS_LINUX)
using base::FilePath;
+#endif
// This is required by googletest to print a readable output on test failures.
BASE_EXPORT extern void PrintTo(const base::FilePath& path, std::ostream* out);
« no previous file with comments | « base/base_paths_mac.mm ('k') | base/file_util_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698