Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

chrome/browser/autofill/android/test_auxiliary_profile_loader_android.h

Index: chrome/browser/autofill/android/test_auxiliary_profile_loader_android.h
diff --git a/chrome/browser/autofill/android/test_auxiliary_profile_loader_android.h b/chrome/browser/autofill/android/test_auxiliary_profile_loader_android.h
new file mode 100644
index 0000000000000000000000000000000000000000..7361a82d64eddcf1a36ded30e1cc4a43643e5c2b
--- /dev/null
+++ b/chrome/browser/autofill/android/test_auxiliary_profile_loader_android.h
@@ -0,0 +1,65 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_AUTOFILL_ANDROID_TEST_AUXILIARY_PROFILE_LOADER_ANDROID_H_
+#define CHROME_BROWSER_AUTOFILL_ANDROID_TEST_AUXILIARY_PROFILE_LOADER_ANDROID_H_
+
+#include "base/compiler_specific.h"
+#include "chrome/browser/autofill/android/auxiliary_profile_loader_android.h"
+
+class TestAuxiliaryProfileLoader : public autofill::AuxiliaryProfileLoaderAndroid {

[Ilya Sherman, 2013/03/09 01:42:58]

nit: 80-col

[apiccion, 2013/03/09 03:43:17]

Done.

+  // Mock object for unit testing |AuxiliaryProfilesAndroid|
+ public:
+  TestAuxiliaryProfileLoader();
+  ~TestAuxiliaryProfileLoader();
+
+  virtual string16 GetFirstName() const;

[Ilya Sherman, 2013/03/09 01:42:58]

nit: This should still include the "OVERRIDE" annotation (applies throughout).

[apiccion, 2013/03/09 03:43:17]

Done.

+  virtual string16 GetMiddleName() const;
+  virtual string16 GetLastName() const;
+  virtual string16 GetSuffix() const;
+
+  virtual string16 GetStreet() const;
+  virtual string16 GetCity() const;
+  virtual string16 GetNeighborhood() const;
+  virtual string16 GetPostalCode() const;
+  virtual string16 GetRegion() const;
+  virtual string16 GetPostOfficeBox() const;
+  virtual string16 GetCountry() const;
+
+  virtual void GetEmailAddresses(std::vector<string16>* emailAddresses) const;
+  virtual void GetPhoneNumbers(std::vector<string16>* phoneNumbers) const;

[Ilya Sherman, 2013/03/09 01:42:58]

nit: hacker_case for both of these.

[apiccion, 2013/03/09 03:43:17]

Done.

+
+  void SetFirstName(string16);
+  void SetMiddleName(string16);
+  void SetLastName(string16);
+  void SetSuffix(string16);

[Ilya Sherman, 2013/03/09 01:42:58]

nit: For all of the SetFoo() methods, pass the parameter by const-reference, and
include names for the parameters.

[apiccion, 2013/03/09 03:43:17]

Done.

+
+  void SetStreet(string16);
+  void SetPobox(string16);
+  void SetNeighborhood(string16);
+  void SetRegion(string16);
+  void SetCity(string16);
+  void SetPostalCode(string16);
+  void SetCountry(string16);
+
+  void SetEmailAddresses(std::vector<string16> emailAddresses);
+  void SetPhoneNumbers(std::vector<string16> emailAddresses);

[Ilya Sherman, 2013/03/09 01:42:58]

nit: hacker_case for both of these.

[apiccion, 2013/03/09 03:43:17]

Done.

+
+ private:
+  string16 street_;
+  string16 pobox_;
+  string16 neighborhood_;
+  string16 region_;
+  string16 city_;
+  string16 postalCode_;

[Ilya Sherman, 2013/03/09 01:42:58]

nit: hacker_case

[apiccion, 2013/03/09 03:43:17]

Done.

[apiccion, 2013/03/09 03:43:17]

Done.

+  string16 country_;
+  string16 firstName_;
+  string16 middleName_;
+  string16 lastName_;

[Ilya Sherman, 2013/03/09 01:42:58]

nit: hacker_case for these three...

[apiccion, 2013/03/09 03:43:17]

Done.

+  string16 suffix_;
+  std::vector<string16> email_addresses_;
+  std::vector<string16> phone_numbers_;
+};
+
+#endif  // CHROME_BROWSER_AUTOFILL_ANDROID_TEST_AUXILIARY_PROFILE_LOADER_ANDROID_H_