chrome/browser/autofill/android/test_auxiliary_profile_loader_android.h - Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

Side by Side Diff: chrome/browser/autofill/android/test_auxiliary_profile_loader_android.h

Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed various nits. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/autofill/android/personal_data_manager_android.cc ('K') | « chrome/browser/autofill/android/personal_data_manager_android.cc ('k') | chrome/browser/autofill/android/test_auxiliary_profile_loader_android.cc » ('j') | chrome/browser/autofill/android/test_auxiliary_profile_loader_android.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_AUTOFILL_ANDROID_TEST_AUXILIARY_PROFILE_LOADER_ANDROID_H_

	6 #define CHROME_BROWSER_AUTOFILL_ANDROID_TEST_AUXILIARY_PROFILE_LOADER_ANDROID_H_

	7

	8 #include "base/compiler_specific.h"

	9 #include "chrome/browser/autofill/android/auxiliary_profile_loader_android.h"

	10

	11 class TestAuxiliaryProfileLoader : public autofill::AuxiliaryProfileLoaderAndroi d {
	Ilya Sherman 2013/03/09 01:42:58 nit: 80-col nit: 80-col apiccion 2013/03/09 03:43:17 Done. Show quoted text On 2013/03/09 01:42:58, Ilya Sherman wrote: > nit: 80-col Done.
	12 // Mock object for unit testing \|AuxiliaryProfilesAndroid\|

	13 public:

	14 TestAuxiliaryProfileLoader();

	15 ~TestAuxiliaryProfileLoader();

	16

	17 virtual string16 GetFirstName() const;
	Ilya Sherman 2013/03/09 01:42:58 nit: This should still include the "OVERRIDE" anno nit: This should still include the "OVERRIDE" annotation (applies throughout). apiccion 2013/03/09 03:43:17 Done. Show quoted text On 2013/03/09 01:42:58, Ilya Sherman wrote: > nit: This should still include the "OVERRIDE" annotation (applies throughout). Done.
	18 virtual string16 GetMiddleName() const;

	19 virtual string16 GetLastName() const;

	20 virtual string16 GetSuffix() const;

	21

	22 virtual string16 GetStreet() const;

	23 virtual string16 GetCity() const;

	24 virtual string16 GetNeighborhood() const;

	25 virtual string16 GetPostalCode() const;

	26 virtual string16 GetRegion() const;

	27 virtual string16 GetPostOfficeBox() const;

	28 virtual string16 GetCountry() const;

	29

	30 virtual void GetEmailAddresses(std::vector<string16>* emailAddresses) const;

	31 virtual void GetPhoneNumbers(std::vector<string16>* phoneNumbers) const;
	Ilya Sherman 2013/03/09 01:42:58 nit: hacker_case for both of these. nit: hacker_case for both of these. apiccion 2013/03/09 03:43:17 Done. Show quoted text On 2013/03/09 01:42:58, Ilya Sherman wrote: > nit: hacker_case for both of these. Done.
	32

	33 void SetFirstName(string16);

	34 void SetMiddleName(string16);

	35 void SetLastName(string16);

	36 void SetSuffix(string16);
	Ilya Sherman 2013/03/09 01:42:58 nit: For all of the SetFoo() methods, pass the par nit: For all of the SetFoo() methods, pass the parameter by const-reference, and include names for the parameters. apiccion 2013/03/09 03:43:17 Done. Show quoted text On 2013/03/09 01:42:58, Ilya Sherman wrote: > nit: For all of the SetFoo() methods, pass the parameter by const-reference, and > include names for the parameters. Done.
	37

	38 void SetStreet(string16);

	39 void SetPobox(string16);

	40 void SetNeighborhood(string16);

	41 void SetRegion(string16);

	42 void SetCity(string16);

	43 void SetPostalCode(string16);

	44 void SetCountry(string16);

	45

	46 void SetEmailAddresses(std::vector<string16> emailAddresses);

	47 void SetPhoneNumbers(std::vector<string16> emailAddresses);
	Ilya Sherman 2013/03/09 01:42:58 nit: hacker_case for both of these. nit: hacker_case for both of these. apiccion 2013/03/09 03:43:17 Done. Show quoted text On 2013/03/09 01:42:58, Ilya Sherman wrote: > nit: hacker_case for both of these. Done.
	48

	49 private:

	50 string16 street_;

	51 string16 pobox_;

	52 string16 neighborhood_;

	53 string16 region_;

	54 string16 city_;

	55 string16 postalCode_;
	Ilya Sherman 2013/03/09 01:42:58 nit: hacker_case nit: hacker_case apiccion 2013/03/09 03:43:17 Done. Show quoted text On 2013/03/09 01:42:58, Ilya Sherman wrote: > nit: hacker_case Done. apiccion 2013/03/09 03:43:17 Done. Show quoted text On 2013/03/09 01:42:58, Ilya Sherman wrote: > nit: hacker_case Done.
	56 string16 country_;

	57 string16 firstName_;

	58 string16 middleName_;

	59 string16 lastName_;
	Ilya Sherman 2013/03/09 01:42:58 nit: hacker_case for these three... nit: hacker_case for these three... apiccion 2013/03/09 03:43:17 Done. Show quoted text On 2013/03/09 01:42:58, Ilya Sherman wrote: > nit: hacker_case for these three... Done.
	60 string16 suffix_;

	61 std::vector<string16> email_addresses_;

	62 std::vector<string16> phone_numbers_;

	63 };

	64

	65 #endif // CHROME_BROWSER_AUTOFILL_ANDROID_TEST_AUXILIARY_PROFILE_LOADER_ANDROID _H_

OLD	NEW