Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

base/android/jni_local_ref_extensions.h

Index: base/android/jni_local_ref_extensions.h
diff --git a/base/android/jni_local_ref_extensions.h b/base/android/jni_local_ref_extensions.h
new file mode 100644
index 0000000000000000000000000000000000000000..3dd6dcd29f229aef281c5e5dbe59c09beb147d54
--- /dev/null
+++ b/base/android/jni_local_ref_extensions.h
@@ -0,0 +1,24 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_ANDROID_JNI_LOCAL_REF_EXTENSIONS_H_
+#define BASE_ANDROID_JNI_LOCAL_REF_EXTENSIONS_H_
+
+#include "base/android/jni_android.h"
+#include "base/android/jni_array.h"
+#include "base/android/jni_string.h"
+
+namespace base {
+namespace android {
+
+std::vector<string16> SafeJavaStringArrayToStringVector(

[Ilya Sherman, 2013/03/01 01:55:04]

Returning a vector by value is generally frowned upon, as it introduces a
potentially expensive copy.  Instead, please pass in the vector as an out-param.

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Docs.

[Ilya Sherman, 2013/03/01 01:55:04]

Honestly, this function doesn't seem like it belongs in base.  Why is it an
onerous burden for callers to null-check their objects?

[apiccion, 2013/03/02 03:37:01]

It bloats the code.
Had it as a private method in the calling file but was asked to move this
outside. I don't know where else to put this.

[Ilya Sherman, 2013/03/05 00:42:37]

Ok, I'll leave that up to base/android OWNERS.

+  ScopedJavaLocalRef<jobjectArray> jarray,
+  JNIEnv* env);
+
+string16 SafeJavaStringToUTF16(ScopedJavaLocalRef<jstring> jstring);

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Docs.

[apiccion, 2013/03/02 03:37:01]

Done.

+
+}  // namespace android
+}  // namespace base
+
+#endif  // BASE_ANDROID_JNI_LOCAL_REF_EXTENSIONS_H_