base/android/jni_local_ref_extensions.h - Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/android/jni_local_ref_extensions.h

Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Autofill nits Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_ANDROID_JNI_LOCAL_REF_EXTENSIONS_H_

	6 #define BASE_ANDROID_JNI_LOCAL_REF_EXTENSIONS_H_

	7

	8 #include "base/android/jni_android.h"

	9 #include "base/android/jni_array.h"

	10 #include "base/android/jni_string.h"

	11

	12 namespace base {

	13 namespace android {

	14

	15 std::vector<string16> SafeJavaStringArrayToStringVector(
	Ilya Sherman 2013/03/01 01:55:04 Returning a vector by value is generally frowned u Returning a vector by value is generally frowned upon, as it introduces a potentially expensive copy. Instead, please pass in the vector as an out-param. Ilya Sherman 2013/03/01 01:55:04 nit: Docs. nit: Docs. Ilya Sherman 2013/03/01 01:55:04 Honestly, this function doesn't seem like it belon Honestly, this function doesn't seem like it belongs in base. Why is it an onerous burden for callers to null-check their objects? apiccion 2013/03/02 03:37:01 It bloats the code. Had it as a private method in Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > Honestly, this function doesn't seem like it belongs in base. Why is it an > onerous burden for callers to null-check their objects? It bloats the code. Had it as a private method in the calling file but was asked to move this outside. I don't know where else to put this. Ilya Sherman 2013/03/05 00:42:37 Ok, I'll leave that up to base/android OWNERS. Show quoted text On 2013/03/02 03:37:01, apiccion wrote: > On 2013/03/01 01:55:04, Ilya Sherman wrote: > > Honestly, this function doesn't seem like it belongs in base. Why is it an > > onerous burden for callers to null-check their objects? > > It bloats the code. > Had it as a private method in the calling file but was asked to move this > outside. I don't know where else to put this. > Ok, I'll leave that up to base/android OWNERS.
	16 ScopedJavaLocalRef<jobjectArray> jarray,

	17 JNIEnv* env);

	18

	19 string16 SafeJavaStringToUTF16(ScopedJavaLocalRef<jstring> jstring);
	Ilya Sherman 2013/03/01 01:55:04 nit: Docs. nit: Docs. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Docs. Done.
	20

	21 } // namespace android

	22 } // namespace base

	23

	24 #endif // BASE_ANDROID_JNI_LOCAL_REF_EXTENSIONS_H_

OLD	NEW

« .gitignore ('K') | « .gitignore ('k') | base/android/jni_local_ref_extensions.cc » ('j') | base/android/jni_local_ref_extensions.cc » ('J')