Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: extensions/browser/api/device_permissions_prompt.cc

Issue 1228103004: Check HID access by device node path instead of sysfs path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/device_permissions_prompt.cc
diff --git a/extensions/browser/api/device_permissions_prompt.cc b/extensions/browser/api/device_permissions_prompt.cc
index cbb458d18f708ee7ff71ac72c26a43943ae21292..941f883a825b455df5fc2520aa8b1496bd205522 100644
--- a/extensions/browser/api/device_permissions_prompt.cc
+++ b/extensions/browser/api/device_permissions_prompt.cc
@@ -24,6 +24,7 @@
#if defined(OS_CHROMEOS)
#include "chromeos/dbus/dbus_thread_manager.h"
#include "chromeos/dbus/permission_broker_client.h"
+#include "device/hid/hid_device_info_linux.h"
#endif // defined(OS_CHROMEOS)
using device::HidDeviceFilter;
@@ -239,8 +240,10 @@ class HidDevicePermissionsPrompt : public DevicePermissionsPrompt::Prompt,
chromeos::PermissionBrokerClient* client =
chromeos::DBusThreadManager::Get()->GetPermissionBrokerClient();
DCHECK(client) << "Could not get permission broker client.";
+ device::HidDeviceInfoLinux* linux_device_info =
+ static_cast<device::HidDeviceInfoLinux*>(device.get());
client->CheckPathAccess(
- device->device_id(),
+ linux_device_info->device_node(),
base::Bind(&HidDevicePermissionsPrompt::AddCheckedDevice, this,
base::Passed(&device_info)));
#else
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698