Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: extensions/browser/api/device_permissions_prompt.cc

Issue 1228103004: Check HID access by device node path instead of sysfs path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/device_permissions_prompt.h" 5 #include "extensions/browser/api/device_permissions_prompt.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/scoped_observer.h" 8 #include "base/scoped_observer.h"
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
11 #include "device/core/device_client.h" 11 #include "device/core/device_client.h"
12 #include "device/hid/hid_device_filter.h" 12 #include "device/hid/hid_device_filter.h"
13 #include "device/hid/hid_device_info.h" 13 #include "device/hid/hid_device_info.h"
14 #include "device/hid/hid_service.h" 14 #include "device/hid/hid_service.h"
15 #include "device/usb/usb_device.h" 15 #include "device/usb/usb_device.h"
16 #include "device/usb/usb_device_filter.h" 16 #include "device/usb/usb_device_filter.h"
17 #include "device/usb/usb_ids.h" 17 #include "device/usb/usb_ids.h"
18 #include "device/usb/usb_service.h" 18 #include "device/usb/usb_service.h"
19 #include "extensions/browser/api/device_permissions_manager.h" 19 #include "extensions/browser/api/device_permissions_manager.h"
20 #include "extensions/common/extension.h" 20 #include "extensions/common/extension.h"
21 #include "extensions/strings/grit/extensions_strings.h" 21 #include "extensions/strings/grit/extensions_strings.h"
22 #include "ui/base/l10n/l10n_util.h" 22 #include "ui/base/l10n/l10n_util.h"
23 23
24 #if defined(OS_CHROMEOS) 24 #if defined(OS_CHROMEOS)
25 #include "chromeos/dbus/dbus_thread_manager.h" 25 #include "chromeos/dbus/dbus_thread_manager.h"
26 #include "chromeos/dbus/permission_broker_client.h" 26 #include "chromeos/dbus/permission_broker_client.h"
27 #include "device/hid/hid_device_info_linux.h"
27 #endif // defined(OS_CHROMEOS) 28 #endif // defined(OS_CHROMEOS)
28 29
29 using device::HidDeviceFilter; 30 using device::HidDeviceFilter;
30 using device::HidService; 31 using device::HidService;
31 using device::UsbDevice; 32 using device::UsbDevice;
32 using device::UsbDeviceFilter; 33 using device::UsbDeviceFilter;
33 using device::UsbService; 34 using device::UsbService;
34 35
35 namespace extensions { 36 namespace extensions {
36 37
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 233
233 // device::HidService::Observer implementation: 234 // device::HidService::Observer implementation:
234 void OnDeviceAdded(scoped_refptr<device::HidDeviceInfo> device) override { 235 void OnDeviceAdded(scoped_refptr<device::HidDeviceInfo> device) override {
235 if (HasUnprotectedCollections(device) && 236 if (HasUnprotectedCollections(device) &&
236 (filters_.empty() || HidDeviceFilter::MatchesAny(device, filters_))) { 237 (filters_.empty() || HidDeviceFilter::MatchesAny(device, filters_))) {
237 scoped_ptr<DeviceInfo> device_info(new HidDeviceInfo(device)); 238 scoped_ptr<DeviceInfo> device_info(new HidDeviceInfo(device));
238 #if defined(OS_CHROMEOS) 239 #if defined(OS_CHROMEOS)
239 chromeos::PermissionBrokerClient* client = 240 chromeos::PermissionBrokerClient* client =
240 chromeos::DBusThreadManager::Get()->GetPermissionBrokerClient(); 241 chromeos::DBusThreadManager::Get()->GetPermissionBrokerClient();
241 DCHECK(client) << "Could not get permission broker client."; 242 DCHECK(client) << "Could not get permission broker client.";
243 device::HidDeviceInfoLinux* linux_device_info =
244 static_cast<device::HidDeviceInfoLinux*>(device.get());
242 client->CheckPathAccess( 245 client->CheckPathAccess(
243 device->device_id(), 246 linux_device_info->device_node(),
244 base::Bind(&HidDevicePermissionsPrompt::AddCheckedDevice, this, 247 base::Bind(&HidDevicePermissionsPrompt::AddCheckedDevice, this,
245 base::Passed(&device_info))); 248 base::Passed(&device_info)));
246 #else 249 #else
247 AddCheckedDevice(device_info.Pass(), true); 250 AddCheckedDevice(device_info.Pass(), true);
248 #endif // defined(OS_CHROMEOS) 251 #endif // defined(OS_CHROMEOS)
249 } 252 }
250 } 253 }
251 254
252 void OnDeviceRemoved(scoped_refptr<device::HidDeviceInfo> device) override { 255 void OnDeviceRemoved(scoped_refptr<device::HidDeviceInfo> device) override {
253 for (auto it = devices_.begin(); it != devices_.end(); ++it) { 256 for (auto it = devices_.begin(); it != devices_.end(); ++it) {
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 content::BrowserContext* context, 369 content::BrowserContext* context,
367 bool multiple, 370 bool multiple,
368 const std::vector<HidDeviceFilter>& filters, 371 const std::vector<HidDeviceFilter>& filters,
369 const HidDevicesCallback& callback) { 372 const HidDevicesCallback& callback) {
370 prompt_ = new HidDevicePermissionsPrompt(extension, context, multiple, 373 prompt_ = new HidDevicePermissionsPrompt(extension, context, multiple,
371 filters, callback); 374 filters, callback);
372 ShowDialog(); 375 ShowDialog();
373 } 376 }
374 377
375 } // namespace extensions 378 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698