Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 1228103004: Check HID access by device node path instead of sysfs path. (Closed)

Created:
5 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check HID access by device node path instead of sysfs path. The permission broker expects clients to request device access by their device node path instead of the sysfs device path (though this is slightly less efficient and perhaps should be changed). The HID permissions prompt code was sending the device ID (which is the sysfs path) instead of the device node path. This patch fixes that. BUG=457899 Committed: https://crrev.com/bf9ea5b48d50d730fe723a8ee58e3ba8b48bfccd Cr-Commit-Position: refs/heads/master@{#338359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M extensions/browser/api/device_permissions_prompt.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Sorry, you're the only person who will understand my patches.
5 years, 5 months ago (2015-07-09 22:38:52 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 5 months ago (2015-07-10 20:22:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228103004/1
5 years, 5 months ago (2015-07-10 20:28:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 21:22:01 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 21:23:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf9ea5b48d50d730fe723a8ee58e3ba8b48bfccd
Cr-Commit-Position: refs/heads/master@{#338359}

Powered by Google App Engine
This is Rietveld 408576698