Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 12281012: Introduce NativeWebContentsModalDialogManagerDelegate interface (Closed)

Created:
7 years, 10 months ago by Mike Wittman
Modified:
7 years, 10 months ago
CC:
chromium-reviews, tfarina, sail+watch_chromium.org, dvh, sail
Visibility:
Public.

Description

Introduce NativeWebContentsModalDialogManagerDelegate interface This CL is part 1 of 6 in the work to remove the WebContentsModalDialog interface. It introduces an interface from the NativeWebContentsModalDialogManager back to the WebContentsModalDialogManager, to decouple these two classes and facilitate independent testing. BUG=157161 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182942

Patch Set 1 #

Total comments: 2

Patch Set 2 : use virtual dtor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -28 lines) Patch
M chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/web_contents_modal_dialog_manager_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/native_web_contents_modal_dialog_manager.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/web_contents_modal_dialog_manager.h View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/web_contents_modal_dialog_manager.cc View 2 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike Wittman
Hi Ben, my next CLs build on top the of opaque type work in https://codereview.chromium.org/12221055 ...
7 years, 10 months ago (2013-02-16 00:43:21 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/12281012/diff/1/chrome/browser/ui/native_web_contents_modal_dialog_manager.h File chrome/browser/ui/native_web_contents_modal_dialog_manager.h (right): https://codereview.chromium.org/12281012/diff/1/chrome/browser/ui/native_web_contents_modal_dialog_manager.h#newcode17 chrome/browser/ui/native_web_contents_modal_dialog_manager.h:17: ~NativeWebContentsModalDialogManagerDelegate() {} virtual dtor
7 years, 10 months ago (2013-02-16 00:53:16 UTC) #2
Mike Wittman
https://codereview.chromium.org/12281012/diff/1/chrome/browser/ui/native_web_contents_modal_dialog_manager.h File chrome/browser/ui/native_web_contents_modal_dialog_manager.h (right): https://codereview.chromium.org/12281012/diff/1/chrome/browser/ui/native_web_contents_modal_dialog_manager.h#newcode17 chrome/browser/ui/native_web_contents_modal_dialog_manager.h:17: ~NativeWebContentsModalDialogManagerDelegate() {} On 2013/02/16 00:53:16, Ben Goodger (Google) wrote: ...
7 years, 10 months ago (2013-02-16 01:41:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/12281012/6031
7 years, 10 months ago (2013-02-16 01:42:56 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 10 months ago (2013-02-16 01:50:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/12281012/6031
7 years, 10 months ago (2013-02-16 03:58:16 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-16 06:33:56 UTC) #7
Message was sent while issue was closed.
Change committed as 182942

Powered by Google App Engine
This is Rietveld 408576698