Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc

Issue 12281012: Introduce NativeWebContentsModalDialogManagerDelegate interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use virtual dtor Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc
diff --git a/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc b/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc
index dc4df3f690a1b71859964e570ad654f1ec20fa4c..2f311aa6bff85aa734a530d537927bf20f5875cb 100644
--- a/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc
+++ b/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc
@@ -32,8 +32,8 @@ class NativeWebContentsModalDialogManagerViews
public views::WidgetObserver {
public:
NativeWebContentsModalDialogManagerViews(
- WebContentsModalDialogManager* manager)
- : manager_(manager) {
+ NativeWebContentsModalDialogManagerDelegate* native_delegate)
+ : native_delegate_(native_delegate) {
}
virtual ~NativeWebContentsModalDialogManagerViews() {
@@ -87,7 +87,7 @@ class NativeWebContentsModalDialogManagerViews
// views::WidgetObserver overrides
virtual void OnWidgetClosing(views::Widget* widget) OVERRIDE {
- manager_->WillClose(static_cast<ConstrainedWindowViews*>(widget));
+ native_delegate_->WillClose(static_cast<ConstrainedWindowViews*>(widget));
observed_widgets_.erase(widget);
}
@@ -98,7 +98,7 @@ class NativeWebContentsModalDialogManagerViews
return widget;
}
- WebContentsModalDialogManager* manager_;
+ NativeWebContentsModalDialogManagerDelegate* native_delegate_;
std::set<views::Widget*> observed_widgets_;
DISALLOW_COPY_AND_ASSIGN(NativeWebContentsModalDialogManagerViews);
@@ -107,6 +107,7 @@ class NativeWebContentsModalDialogManagerViews
} // namespace
NativeWebContentsModalDialogManager* WebContentsModalDialogManager::
-CreateNativeManager(WebContentsModalDialogManager* manager) {
- return new NativeWebContentsModalDialogManagerViews(manager);
+CreateNativeManager(
+ NativeWebContentsModalDialogManagerDelegate* native_delegate) {
+ return new NativeWebContentsModalDialogManagerViews(native_delegate);
}
« no previous file with comments | « chrome/browser/ui/native_web_contents_modal_dialog_manager.h ('k') | chrome/browser/ui/web_contents_modal_dialog_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698