Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1228093005: Revert of Clang on Windows: Remove -Wno-unused-variable. (Closed)

Created:
5 years, 5 months ago by Matt Giuca
Modified:
5 years, 5 months ago
Reviewers:
Nico, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-unused-variables
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clang on Windows: Remove -Wno-unused-variable. (patchset #3 id:40001 of https://codereview.chromium.org/1226573002/) Reason for revert: Broke Clang build on Windows according to http://crbug.com/505319#c30. Those warnings should be fixed before relanding. Original issue's description: > Clang on Windows: Remove -Wno-unused-variable. > > Unused variables are now errors. However, since lots of third-party code > has unused variables, added a blanket suppression to all third-party > code. > > BUG=505319 > > Committed: https://crrev.com/3371ccbd9d83e1031c5891520e88acbc9c1859a0 > Cr-Commit-Position: refs/heads/master@{#338242} TBR=garykac@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=505319 Committed: https://crrev.com/ff68a3ba6f2dc9b226047b3355c135f73352570e Cr-Commit-Position: refs/heads/master@{#338253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M build/common.gypi View 2 chunks +1 line, -3 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M remoting/remoting_host_win.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Matt Giuca
Created Revert of Clang on Windows: Remove -Wno-unused-variable.
5 years, 5 months ago (2015-07-10 07:52:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228093005/1
5 years, 5 months ago (2015-07-10 07:52:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 07:53:21 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ff68a3ba6f2dc9b226047b3355c135f73352570e Cr-Commit-Position: refs/heads/master@{#338253}
5 years, 5 months ago (2015-07-10 07:54:09 UTC) #4
Nico
5 years, 5 months ago (2015-07-10 23:27:42 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1232543005/ by thakis@chromium.org.

The reason for reverting is: might be better now?.

Powered by Google App Engine
This is Rietveld 408576698