Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2119)

Unified Diff: build/common.gypi

Issue 1228093005: Revert of Clang on Windows: Remove -Wno-unused-variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-unused-variables
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c4b652da23cbfb3080918887a90f4ff37c4c21cf..6a13f95a4662322e8acfe4acc3baf768b7c4bb8b 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3111,9 +3111,6 @@
# TODO(mgiuca): Move this suppression into individual third-party
# libraries as required. http://crbug.com/505301.
'-Wno-overloaded-virtual',
- # Lots of third-party libraries have unused variables. Instead of
- # suppressing them individually, we just blanket suppress them here.
- '-Wno-unused-variable',
],
},
'conditions': [
@@ -5738,6 +5735,7 @@
'-Wno-unused-function', # http://crbug.com/505316
'-Wno-unused-private-field', # http://crbug.com/505317
'-Wno-unused-value', # http://crbug.com/505318
+ '-Wno-unused-variable', # http://crbug.com/505319
'-Wno-unused-local-typedef', # http://crbug.com/411648
],
},
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698