Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: sdk/lib/_internal/compiler/implementation/dart2js.dart

Issue 12280012: Apply Issue 12253048: "Add back --disallow-unsafe-eval for M3. This flag will be temporarily disabl… (Closed) Base URL: http://dart.googlecode.com/svn/trunk/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/js_backend/backend.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/dart2js.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/dart2js.dart (revision 18600)
+++ sdk/lib/_internal/compiler/implementation/dart2js.dart (working copy)
@@ -151,12 +151,6 @@
return passThrough('--categories=${categories.join(",")}');
}
- // TODO(8522): Remove this method once option is restored.
- complainAboutDisallowUnsafeEval(String argument) {
- fail('Error: $argument is currently not supported, '
- 'see http://dartbug.com/8522');
- }
-
handleShortOptions(String argument) {
var shortOptions = argument.substring(1).split("");
for (var shortOption in shortOptions) {
@@ -202,8 +196,7 @@
(_) => passThrough('--enable-concrete-type-inference')),
new OptionHandler(r'--help|/\?|/h', (_) => wantHelp = true),
new OptionHandler('--package-root=.+|-p.+', setPackageRoot),
- new OptionHandler('--disallow-unsafe-eval',
- complainAboutDisallowUnsafeEval),
+ new OptionHandler('--disallow-unsafe-eval', passThrough),
new OptionHandler('--analyze-all', passThrough),
new OptionHandler('--analyze-only', setAnalyzeOnly),
new OptionHandler('--disable-native-live-type-analysis', passThrough),
@@ -441,18 +434,12 @@
Disable the optimization that removes unused native types from dart:html
and related libraries.
-'''
-/* TODO(8522): Restore this comment once option is restored.
-'''
--disallow-unsafe-eval
Disable dynamic generation of code in the generated output. This is
necessary to satisfy CSP restrictions (see http://www.w3.org/TR/CSP/).
This flag is not continuously tested. Please report breakages and we
will fix them as soon as possible.
-'''
-*/
-'''
--reject-deprecated-language-features
Reject deprecated language features. Without this option, the
compiler will accept language features that are no longer valid
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/js_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698