Apply Issue 12253048: "Add back --disallow-unsafe-eval for M3. This flag will be temporarily disabl…

sdk/lib/_internal/compiler/implementation/dart2js.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js;
 
 import 'dart:async';
 import 'dart:collection' show Queue, LinkedHashMap;
 import 'dart:io';
 import 'dart:uri';
@@ skipping 133 matching lines @@
       for (String category in categories) {
         if (!allowedCategories.contains(category)) {
           fail('Error: unsupported library category "$category", '
                'supported categories are: $allowedCategoriesString');
         }
       }
     }
     return passThrough('--categories=${categories.join(",")}');
   }
 
-  // TODO(8522): Remove this method once option is restored.
-  complainAboutDisallowUnsafeEval(String argument) {
-    fail('Error: $argument is currently not supported, '
-         'see http://dartbug.com/8522');
-  }
-
   handleShortOptions(String argument) {
     var shortOptions = argument.substring(1).split("");
     for (var shortOption in shortOptions) {
       switch (shortOption) {
         case 'v':
           diagnosticHandler.verbose = true;
           break;
         case 'h':
         case '?':
           wantHelp = true;
@@ skipping 25 matching lines @@
     new OptionHandler('--disable-diagnostic-colors',
                       (_) => diagnosticHandler.enableColors = false),
     new OptionHandler('--enable-diagnostic-colors',
                       (_) => diagnosticHandler.enableColors = true),
     new OptionHandler('--enable[_-]checked[_-]mode|--checked',
                       (_) => passThrough('--enable-checked-mode')),
     new OptionHandler('--enable-concrete-type-inference',
                       (_) => passThrough('--enable-concrete-type-inference')),
     new OptionHandler(r'--help|/\?|/h', (_) => wantHelp = true),
     new OptionHandler('--package-root=.+|-p.+', setPackageRoot),
-    new OptionHandler('--disallow-unsafe-eval',
-                      complainAboutDisallowUnsafeEval),
+    new OptionHandler('--disallow-unsafe-eval', passThrough),
     new OptionHandler('--analyze-all', passThrough),
     new OptionHandler('--analyze-only', setAnalyzeOnly),
     new OptionHandler('--disable-native-live-type-analysis', passThrough),
     new OptionHandler('--reject-deprecated-language-features', passThrough),
     new OptionHandler('--report-sdk-use-of-deprecated-language-features',
                       passThrough),
     new OptionHandler('--categories=.*', setCategories),
 
     // The following two options must come last.
     new OptionHandler('-.*', (String argument) {
@@ skipping 217 matching lines @@
     Do not generate a call to main if either of the following
     libraries are used: dart:dom, dart:html dart:io.
 
   --enable-concrete-type-inference
     Enable experimental concrete type inference.
 
   --disable-native-live-type-analysis
     Disable the optimization that removes unused native types from dart:html
     and related libraries.
 
-'''
-/* TODO(8522): Restore this comment once option is restored.
-'''
   --disallow-unsafe-eval
     Disable dynamic generation of code in the generated output. This is
     necessary to satisfy CSP restrictions (see http://www.w3.org/TR/CSP/).
     This flag is not continuously tested. Please report breakages and we
     will fix them as soon as possible.
 
-'''
-*/
-'''
   --reject-deprecated-language-features
     Reject deprecated language features.  Without this option, the
     compiler will accept language features that are no longer valid
     according to The Dart Programming Language Specification, version
     0.12, M1.
 
   --report-sdk-use-of-deprecated-language-features
     Report use of deprecated features in Dart platform libraries.
     Without this option, the compiler will silently accept use of
     deprecated language features from these libraries.  The option
@@ skipping 34 matching lines @@
     } catch (ignored) {
       print('Internal error: error while printing exception');
     }
     try {
       print(trace);
     } finally {
       exit(253); // 253 is recognized as a crash by our test scripts.
     }
   }
 }