Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: sky/build/skyx.gni

Issue 1227973002: Build skyx packages by default (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: typo Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/build/sky_app.gni ('k') | sky/sdk/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/build/skyx.gni
diff --git a/sky/build/skyx.gni b/sky/build/skyx.gni
index 2306558d207e6a88fc0ba0e200b113db4f94ce75..f0d9c235fb766b42aeb209a0d049b8f0707754c0 100644
--- a/sky/build/skyx.gni
+++ b/sky/build/skyx.gni
@@ -2,15 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-declare_args() {
- # Controls whether we build app.skyx bundles in the sky_app template below.
- # An app.skyx bundle contains all the code an resources needed to run a Sky
- # app offline. Unfortunately, we don't yet have all the Dart packages we need
- # to create skyx packages installed on the build bots, so this functionality
- # is currently disabled. This flag allows for local testing of this feature.
- enable_skyx = false
-}
-
package_root = "$root_gen_dir/dart-pkg/packages"
template("skyx") {
@@ -75,6 +66,8 @@ template("skyx") {
script = "//sky/tools/skyx.py"
args = [
+ "--package-root",
+ rebase_path(package_root, root_build_dir),
"--asset-base",
rebase_path(asset_base, root_build_dir),
"--snapshot",
@@ -93,14 +86,13 @@ template("skyx") {
deps = [
":gen_${bundle_prefix}_snapshot",
+ "//third_party/dart-pkg",
]
}
group(target_name) {
- if (enable_skyx) {
- deps = [
- ":gen_${bundle_prefix}_bundle",
- ]
- }
+ deps = [
+ ":gen_${bundle_prefix}_bundle",
+ ]
}
}
« no previous file with comments | « sky/build/sky_app.gni ('k') | sky/sdk/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698