Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: sky/build/sky_app.gni

Issue 1227973002: Build skyx packages by default (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: typo Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/build/skyx.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/build/sky_app.gni
diff --git a/sky/build/sky_app.gni b/sky/build/sky_app.gni
index 34148ae2816fd85c5e33fffd3a16e5c2de1da222..950bf82c78b860385d1d7fa3bf075bf2e233c256 100644
--- a/sky/build/sky_app.gni
+++ b/sky/build/sky_app.gni
@@ -2,11 +2,16 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("//build/config/android/rules.gni")
import("//sky/build/skyx.gni")
template("sky_app") {
- skyx("app") {
+ skyx_target_name = target_name
+
+ if (is_android) {
+ skyx_target_name = "app"
+ }
+
+ skyx(skyx_target_name) {
main_dart = invoker.main_dart
if (defined(invoker.manifest)) {
@@ -18,65 +23,65 @@ template("sky_app") {
}
}
- bundle_prefix = target_name
+ if (is_android) {
+ import("//build/config/android/rules.gni")
- copy("copy_${bundle_prefix}_bundle") {
- sources = [
- "$target_gen_dir/app.skyx",
- ]
- outputs = [
- "$target_gen_dir/${bundle_prefix}.skyx",
- ]
+ bundle_prefix = target_name
- deps = [
- ":app",
- ]
- }
+ copy("copy_${bundle_prefix}_bundle") {
+ sources = [
+ "$target_gen_dir/app.skyx",
+ ]
+ outputs = [
+ "$target_gen_dir/${bundle_prefix}.skyx",
+ ]
- copy_ex("assets") {
- clear_dir = true
- dest = "$target_gen_dir/assets"
+ deps = [
+ ":app",
+ ]
+ }
- sources = [
- "$root_build_dir/icudtl.dat",
- ]
- deps = [
- "//third_party/icu",
- ]
+ copy_ex("assets") {
+ clear_dir = true
+ dest = "$target_gen_dir/assets"
- if (enable_skyx) {
- sources += [ "$target_gen_dir/app.skyx" ]
- deps += [ ":copy_${bundle_prefix}_bundle" ]
+ sources = [
+ "$root_build_dir/icudtl.dat",
+ "$target_gen_dir/app.skyx",
+ ]
+ deps = [
+ "//third_party/icu",
+ ":copy_${bundle_prefix}_bundle",
+ ]
if (defined(invoker.bundles)) {
foreach(bundle, invoker.bundles) {
bundle_gen_dir = get_label_info(bundle, "target_gen_dir")
bundle_name = get_label_info(bundle, "name")
-
sources += [ "$bundle_gen_dir/${bundle_name}.skyx" ]
deps += [ bundle ]
}
}
}
- }
- android_apk(target_name) {
- apk_name = invoker.apk_name
- android_manifest = "apk/AndroidManifest.xml"
+ android_apk(target_name) {
+ apk_name = invoker.apk_name
+ android_manifest = "apk/AndroidManifest.xml"
- native_libs = [ "libsky_shell.so" ]
- asset_location = "$target_gen_dir/assets"
+ native_libs = [ "libsky_shell.so" ]
+ asset_location = "$target_gen_dir/assets"
- deps = [
- "//base:base_java",
- "//sky/shell:assets",
- "//sky/shell:java",
- "//sky/shell:sky_shell",
- ":assets",
- ]
+ deps = [
+ "//base:base_java",
+ "//sky/shell:assets",
+ "//sky/shell:java",
+ "//sky/shell:sky_shell",
+ ":assets",
+ ]
- if (defined(invoker.deps)) {
- deps += invoker.deps
+ if (defined(invoker.deps)) {
+ deps += invoker.deps
+ }
}
}
}
« no previous file with comments | « no previous file | sky/build/skyx.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698