Issue 1227973002: Build skyx packages by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1227973002: Build skyx packages by default (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Build skyx packages by default Now that we have all the Dart packages we need in //third_party, we can build skyx bundles by default. As part of this change, I've made it possible to build skyx bundles on Linux and I've made the gn target names of the mojoms in //sky/services consistent with each other and with //mojo/services/public. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/db5b2cd9e478247de2693081c89ff10f952ccc30

Patch Set 1 #

Patch Set 2 : typo #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -147 lines)			Patch
M	sky/build/sky_app.gni	View	1	2 chunks	+47 lines, -42 lines	0 comments	Download
M	sky/build/skyx.gni	View		3 chunks	+6 lines, -14 lines	0 comments	Download
M	sky/sdk/BUILD.gn	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	sky/sdk/example/BUILD.gn	View		1 chunk	+7 lines, -11 lines	0 comments	Download
M	sky/sdk/example/demo_launcher/BUILD.gn	View		1 chunk	+8 lines, -7 lines	0 comments	Download
M	sky/sdk/example/mine_digger/BUILD.gn	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	sky/sdk/example/stocks/BUILD.gn	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	sky/services/activity/BUILD.gn	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	sky/services/engine/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/services/media/BUILD.gn	View		2 chunks	+23 lines, -17 lines	0 comments	Download
M	sky/services/testing/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/shell/BUILD.gn	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/tools/skyx.py	View		2 chunks	+2 lines, -0 lines	0 comments	Download
D	sky/tools/skyx/pubspec.lock	View		1 chunk	+0 lines, -35 lines	0 comments	Download
M	sky/tools/tester/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/viewer/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-07-09 15:39:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
db5b2cd9e478247de2693081c89ff10f952ccc30 (presubmit successful).

Expand Messages | Collapse Messages