chromecast/crash/linux/minidump_generator.h - Issue 1227963002: Replace system IO calls in chromecast/crash with Chrome utilities.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/crash/linux/minidump_generator.h

Issue 1227963002: Replace system IO calls in chromecast/crash with Chrome utilities. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: nit. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/crash/linux/dummy_minidump_generator_unittest.cc ('k') | chromecast/crash/linux/synchronized_minidump_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/crash/linux/minidump_generator.h

diff --git a/chromecast/crash/linux/minidump_generator.h b/chromecast/crash/linux/minidump_generator.h

index 9780e430ec7102dcb1ba00fb6523205131114cf6..0601dea5d2e68d9527311f7ac7aa6135afffbc2e 100644

--- a/chromecast/crash/linux/minidump_generator.h

+++ b/chromecast/crash/linux/minidump_generator.h

@@ -9,12 +9,15 @@

namespace chromecast {

+// An interface to generate a minidump at a given filepath.

class MinidumpGenerator {

public:

virtual ~MinidumpGenerator() {}

- // Interface to generate a minidump file in given path.

- // This is called inside MinidumpWriter::DoWorkLocked().

+ // Generates a minidump file at |minidump_path|. This method should only be

+ // called on a thread without IO restrictions, as non-trivial implementations

+ // will almost certainly require IO permissions. Returns true if minidump was

+ // successfully generated.

virtual bool Generate(const std::string& minidump_path) = 0;

};