Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chromecast/crash/linux/synchronized_minidump_manager.cc

Issue 1227963002: Replace system IO calls in chromecast/crash with Chrome utilities. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: nit. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/linux/minidump_generator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/linux/synchronized_minidump_manager.cc
diff --git a/chromecast/crash/linux/synchronized_minidump_manager.cc b/chromecast/crash/linux/synchronized_minidump_manager.cc
index 358427a2dd31a3532e82a9d6703bd78f00f161e2..c21e6255d5e9c474b8f4c98a9f3219e7c1c05d69 100644
--- a/chromecast/crash/linux/synchronized_minidump_manager.cc
+++ b/chromecast/crash/linux/synchronized_minidump_manager.cc
@@ -153,12 +153,10 @@ int SynchronizedMinidumpManager::ParseLockFile() {
// Grab each entry.
while (std::getline(in, entry)) {
scoped_ptr<DumpInfo> info(new DumpInfo(entry));
- if (info->valid() && info->crashed_process_dump().size() > 0) {
+ if (info->valid() && info->crashed_process_dump().size() > 0)
dumps->push_back(info.Pass());
- } else {
- LOG(WARNING) << "Entry is not valid: " << entry;
- return -1;
- }
+ else
+ LOG(WARNING) << "Ignoring invalid entry: " << entry;
}
dump_metadata_ = dumps.Pass();
« no previous file with comments | « chromecast/crash/linux/minidump_generator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698