Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1227953008: Reland of Precompile more in Blink in Windows for faster compilations (Closed)

Created:
5 years, 5 months ago by Daniel Bratell
Modified:
5 years, 5 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, haraken, tasak (please_use_google.com)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Precompile more in Blink in Windows for faster compilations One reason Blink is slow to compile is that there is a lot of code included in every compilation unit since everything depends on either LayoutObject.h or Document.h and those in turn include huge portions of the rest of Blink. By precompiling LayoutObject.h and Document.h the compilation of core and modules in Blink can be 4 times faster (4 minutes instead of 19 minutes on my computer). The downside is that it will introduce Document.h and LayoutObject.h also in compilation units that didn't expect it, for instance XPathGrammer.y that suddenly will have both blink::Path and blink::XPath::Path in scope (and blink::Filter / blink::XPath::Filter) Note that distributed compilation system disables precompiled headers globally so this will *not* make trybots faster. This is a new attempt at this change after bug 511945 scared us into reverting it. We still do not know the exact cause of 511945 but we are making another attempt with this. BUG=495697 R=thakis@chromium.org,sigbjornf@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -9 lines) Patch
M Source/core/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gyp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/Frame.h View 2 chunks +1 line, -1 line 0 comments Download
A Source/core/win/Precompile-core.h View 1 chunk +33 lines, -0 lines 0 comments Download
A Source/core/win/Precompile-core.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
A Source/core/win/precompile-core.gypi View 1 chunk +29 lines, -0 lines 0 comments Download
M Source/core/xml/XPathGrammar.y View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/modules.gyp View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/cpp.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
Daniel Bratell
Created Reland of Precompile more in Blink in Windows for faster compilations
5 years, 5 months ago (2015-07-17 14:04:04 UTC) #1
sof
lgtm - makes good sense to reland to try determine where that bot ailment came ...
5 years, 5 months ago (2015-07-19 17:07:53 UTC) #2
Nico
is there a bug somewhere that summarizes what the failure looked like? it went away ...
5 years, 5 months ago (2015-07-19 17:16:23 UTC) #3
sof
On 2015/07/19 17:16:23, Nico wrote: > is there a bug somewhere that summarizes what the ...
5 years, 5 months ago (2015-07-19 18:11:24 UTC) #4
Nico
lgtm
5 years, 5 months ago (2015-07-19 18:25:25 UTC) #5
Nico
(I do wish that there had been left more details on a bug somewhere: Link ...
5 years, 5 months ago (2015-07-19 18:26:05 UTC) #6
Daniel Bratell
Thanks! I've opened https://code.google.com/p/chromium/issues/detail?id=511945 with lots of links to builds and explanation of various events ...
5 years, 5 months ago (2015-07-20 12:09:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227953008/1
5 years, 5 months ago (2015-07-20 12:09:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199168
5 years, 5 months ago (2015-07-20 13:41:21 UTC) #10
Daniel Bratell
5 years, 5 months ago (2015-07-24 09:47:20 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1259563002/ by bratell@opera.com.

The reason for reverting is: A chromium build bot broke with bad headers again.
(see bug)

The pch file does not seem to be recompiled when it should be.

BUG=511945.

Powered by Google App Engine
This is Rietveld 408576698