Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 12279017: Revert 140571 (Closed)

Created:
8 years ago by jamesr
Modified:
8 years ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Revert 140571 > https://bugs.webkit.org/show_bug.cgi?id=107628 > Sometimes scroll position is jerky during rubber-band, affects nytimes.com > -and corresponding- > <rdar://problem/12679549> > > Reviewed by Simon Fraser. > > The basic problem here is that isRubberBandInProgress() was only implemented for > main thread scrolling. So when we were actually scrolling on the scrolling thread, > that function would always return false regardless. > > New ScrollableArea virtual function isRubberBandInProgress() will allow us to ask > the ScrollingCoordinator when the scrolling thread is scrolling, or the > ScrollAnimator otherwise. > * page/FrameView.cpp: > (WebCore::FrameView::isRubberBandInProgress): > * page/FrameView.h: > (FrameView): > * platform/ScrollableArea.h: > (WebCore::ScrollableArea::isRubberBandInProgress): > > New ScrollingCoordinator function isRubberBandInProgress() always returns false > for non-Mac ports, and is overridden in ScrollingCoordinatorMac to consult the > ScrollingTree. > * page/scrolling/ScrollingCoordinator.h: > (WebCore::ScrollingCoordinator::isRubberBandInProgress): > * page/scrolling/mac/ScrollingCoordinatorMac.h: > (ScrollingCoordinatorMac): > * page/scrolling/mac/ScrollingCoordinatorMac.mm: > (WebCore::ScrollingCoordinatorMac::isRubberBandInProgress): > > New variable m_mainFrameIsRubberBanding keeps track of whether there is currently > a rubber-band happening on the scrolling thread. > * page/scrolling/ScrollingTree.cpp: > (WebCore::ScrollingTree::ScrollingTree): > (WebCore::ScrollingTree::isRubberBandInProgress): > (WebCore::ScrollingTree::setMainFrameIsRubberBanding): > * page/scrolling/ScrollingTree.h: > (ScrollingTree): > (WebCore::ScrollingTree::rootNode): > > Call setMainFrameIsRubberBanding() whenever the stretchAmount is calculated and > whenever we stop the rubber-band timer. > * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm: > (WebCore::ScrollingTreeScrollingNodeMac::stretchAmount): > (WebCore::ScrollingTreeScrollingNodeMac::stopSnapRubberbandTimer): > > Consult FrameView for isRubberBandInProgress(). > * platform/ScrollView.cpp: > (WebCore::ScrollView::updateScrollbars): > > TBR=jamesr@chromium.org BUG=173009 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -64 lines) Patch
M Source/WebCore/page/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/page/FrameView.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M Source/WebCore/page/scrolling/ScrollingCoordinator.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/page/scrolling/ScrollingTree.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/page/scrolling/ScrollingTree.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/WebCore/platform/ScrollView.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/WebCore/platform/ScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
8 years ago (2013-02-15 22:39:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698