Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: sandbox/win/src/sharedmem_ipc_server.h

Issue 1227863003: Sandbox: Remove job_object from (IPCInfo::)ClientInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/win/src/crosscall_server.h ('k') | sandbox/win/src/sharedmem_ipc_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/sharedmem_ipc_server.h
diff --git a/sandbox/win/src/sharedmem_ipc_server.h b/sandbox/win/src/sharedmem_ipc_server.h
index 94d6959b81259fbb768e23df7d715348dfb79bdf..62016540a2968f9fcbdde2f9b7a77763c08e2794 100644
--- a/sandbox/win/src/sharedmem_ipc_server.h
+++ b/sandbox/win/src/sharedmem_ipc_server.h
@@ -36,14 +36,17 @@ namespace sandbox {
class SharedMemIPCServer {
public:
// Creates the IPC server.
- // target_process: handle to the target process. It must be suspended.
+ // target_process: handle to the target process. It must be suspended. It is
+ // unfortunate to receive a raw handle (and store it inside this object) as
+ // that dilutes ownership of the process, but in practice a SharedMemIPCServer
+ // is owned by TargetProcess, which calls this method, and owns the handle, so
+ // everything is safe. If that changes, we should break this dependency and
+ // duplicate the handle instead.
// target_process_id: process id of the target process.
- // target_job: the job object handle associated with the target process.
// thread_provider: a thread provider object.
// dispatcher: an object that can service IPC calls.
SharedMemIPCServer(HANDLE target_process, DWORD target_process_id,
- HANDLE target_job, ThreadProvider* thread_provider,
- Dispatcher* dispatcher);
+ ThreadProvider* thread_provider, Dispatcher* dispatcher);
~SharedMemIPCServer();
@@ -113,9 +116,6 @@ class SharedMemIPCServer {
// The target process id associated with the IPC object.
DWORD target_process_id_;
- // The target object is inside a job too.
- HANDLE target_job_object_;
-
// The dispatcher handles 'ready' IPC calls.
Dispatcher* call_dispatcher_;
« no previous file with comments | « sandbox/win/src/crosscall_server.h ('k') | sandbox/win/src/sharedmem_ipc_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698