Sandbox: Remove job_object from (IPCInfo::)ClientInfo.

sandbox/win/src/sharedmem_ipc_server.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SANDBOX_SRC_SHAREDMEM_IPC_SERVER_H_
 #define SANDBOX_SRC_SHAREDMEM_IPC_SERVER_H_
 
 #include <list>
 
 #include "base/basictypes.h"
@@ skipping 18 matching lines @@
 // ThreadPingEventReady callback. The IPC server then retrieves the buffer,
 // marshals it into a CrossCallParam object and calls the Dispatcher, who is in
 // charge of fulfilling the IPC request.
 namespace sandbox {
 
 // the shared memory implementation of the IPC server. There should be one
 // of these objects per target (IPC client) process
 class SharedMemIPCServer {
  public:
   // Creates the IPC server.
-  // target_process: handle to the target process. It must be suspended.
+  // target_process: handle to the target process. It must be suspended. It is
+  // unfortunate to receive a raw handle (and store it inside this object) as
+  // that dilutes ownership of the process, but in practice a SharedMemIPCServer
+  // is owned by TargetProcess, which calls this method, and owns the handle, so
+  // everything is safe. If that changes, we should break this dependency and
+  // duplicate the handle instead.
   // target_process_id: process id of the target process.
-  // target_job: the job object handle associated with the target process.
   // thread_provider: a thread provider object.
   // dispatcher: an object that can service IPC calls.
   SharedMemIPCServer(HANDLE target_process, DWORD target_process_id,
-                     HANDLE target_job, ThreadProvider* thread_provider,
-                     Dispatcher* dispatcher);
+                     ThreadProvider* thread_provider, Dispatcher* dispatcher);
 
   ~SharedMemIPCServer();
 
   // Initializes the server structures, shared memory structures and
   // creates the kernels events used to signal the IPC.
   bool Init(void* shared_mem, uint32 shared_size, uint32 channel_size);
 
  private:
   // Allow tests to be marked DISABLED_. Note that FLAKY_ and FAILS_ prefixes
   // do not work with sandbox tests.
@@ skipping 49 matching lines @@
   // The thread provider provides the threads that call back into this object
   // when the IPC events fire.
   ThreadProvider* thread_provider_;
 
   // The IPC object is associated with a target process.
   HANDLE target_process_;
 
   // The target process id associated with the IPC object.
   DWORD target_process_id_;
 
-  // The target object is inside a job too.
-  HANDLE target_job_object_;
-
   // The dispatcher handles 'ready' IPC calls.
   Dispatcher* call_dispatcher_;
 
   DISALLOW_COPY_AND_ASSIGN(SharedMemIPCServer);
 };
 
 }  // namespace sandbox
 
 #endif  // SANDBOX_SRC_SHAREDMEM_IPC_SERVER_H_