Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1227833002: Measure usage of Document.createTouch() (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Measure usage of Document.createTouch() This is for the same reason as the init*Event() methods, to know if making all the arguments non-optional is likely safe or not: https://codereview.chromium.org/1215893006 Also remove the webkit prefixes on the arguments, as the corresponding attribute are now unprefixed on the Touch interface. BUG=460722 R=rbyers@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M Source/core/dom/Document.idl View 1 chunk +11 lines, -12 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
philipj_slow
5 years, 5 months ago (2015-07-08 22:00:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227833002/1
5 years, 5 months ago (2015-07-08 22:01:04 UTC) #3
Rick Byers
lgtm
5 years, 5 months ago (2015-07-08 22:10:33 UTC) #4
Rick Byers
On 2015/07/08 22:10:33, Rick Byers wrote: > lgtm FWIW, from other evidence (eg. lack of ...
5 years, 5 months ago (2015-07-08 22:11:05 UTC) #5
philipj_slow
On 2015/07/08 22:11:05, Rick Byers wrote: > On 2015/07/08 22:10:33, Rick Byers wrote: > > ...
5 years, 5 months ago (2015-07-08 22:17:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227833002/1
5 years, 5 months ago (2015-07-09 11:01:05 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 11:52:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198595

Powered by Google App Engine
This is Rietveld 408576698