Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 1215893006: Add UseCounters for init*Event methods that aren't already measured (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, arv+blink, vivekg, mlamouri+watch-blink_chromium.org, vivekg_samsung, timvolodine, mvanouwerkerk+watch_chromium.org, Inactive
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add UseCounters for init*Event methods that aren't already measured These methods systematically have "[Default=Undefined] optional" arguments where the spec (if any) has non-optional arguments. Usage of most of these is likely low, so just measure them all to see where the change can be made without further investigation. Also change a few argument names that were not per their specs. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -86 lines) Patch
M Source/core/events/CompositionEvent.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/events/CustomEvent.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/events/Event.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/events/KeyboardEvent.idl View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/events/MouseEvent.idl View 1 chunk +15 lines, -15 lines 0 comments Download
M Source/core/events/MutationEvent.idl View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/events/TouchEvent.idl View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/core/events/UIEvent.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/modules/device_orientation/DeviceMotionEvent.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/modules/device_orientation/DeviceOrientationEvent.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/modules/storage/StorageEvent.idl View 1 chunk +8 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
philipj_slow
PTAL and CQ?
5 years, 5 months ago (2015-07-06 21:25:11 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215893006/1
5 years, 5 months ago (2015-07-06 21:25:24 UTC) #4
Rick Byers
lgtm
5 years, 5 months ago (2015-07-06 21:32:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215893006/1
5 years, 5 months ago (2015-07-06 21:35:09 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 22:37:13 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198345

Powered by Google App Engine
This is Rietveld 408576698