Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1227823005: Revert of Cleanup viewport scrolling for future scroll customization work. (Closed)

Created:
5 years, 5 months ago by tdresser
Modified:
5 years, 5 months ago
Reviewers:
Ian Vollick, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Cleanup viewport scrolling for future scroll customization work. (patchset #2 id:20001 of https://codereview.chromium.org/1223713004/) Reason for revert: See crbug.com/508509. We need to fix this case before relanding. Original issue's description: > Cleanup viewport scrolling for future scroll customization work. > > Viewport scrolling previously returned a struct of information about > what scrolled. This complicated scroll customization. This patch makes > |Viewport::ScrollBy| return a single |Vector2dF|, as well as performing > some other cleanup that will simplify scroll customization. > > BUG=505851 > TEST=LayerTreeHostImplTest, WebContentsViewAuraTest.VerticalOverscroll > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/3e773d7aeba1eb0077a7907d0f5ff2e72e1c6753 > Cr-Commit-Position: refs/heads/master@{#337694} TBR=vollick@chromium.org,enne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=505851 Committed: https://crrev.com/8fe1dd9f7bf1fe50493fc0b9d0300315b127edcd Cr-Commit-Position: refs/heads/master@{#338071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -52 lines) Patch
M cc/layers/viewport.h View 2 chunks +10 lines, -4 lines 0 comments Download
M cc/layers/viewport.cc View 1 chunk +28 lines, -18 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 4 chunks +35 lines, -26 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tdresser
Created Revert of Cleanup viewport scrolling for future scroll customization work.
5 years, 5 months ago (2015-07-09 17:18:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227823005/1
5 years, 5 months ago (2015-07-09 17:19:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 17:21:14 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 17:22:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fe1dd9f7bf1fe50493fc0b9d0300315b127edcd
Cr-Commit-Position: refs/heads/master@{#338071}

Powered by Google App Engine
This is Rietveld 408576698