Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: Source/modules/indexeddb/IDBTransaction.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/indexeddb/IDBRequestTest.cpp ('k') | Source/modules/indexeddb/IDBTransactionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/indexeddb/IDBTransaction.h
diff --git a/Source/modules/indexeddb/IDBTransaction.h b/Source/modules/indexeddb/IDBTransaction.h
index 3c90681ac02322160f1136ffd3d040e15d847ee0..b5e7251675dd7c4e1f2edb185635e606f1de3b70 100644
--- a/Source/modules/indexeddb/IDBTransaction.h
+++ b/Source/modules/indexeddb/IDBTransaction.h
@@ -58,7 +58,7 @@ class MODULES_EXPORT IDBTransaction final
public:
static IDBTransaction* create(ScriptState*, int64_t, const HashSet<String>& objectStoreNames, WebIDBTransactionMode, IDBDatabase*);
static IDBTransaction* create(ScriptState*, int64_t, IDBDatabase*, IDBOpenDBRequest*, const IDBDatabaseMetadata& previousMetadata);
- virtual ~IDBTransaction();
+ ~IDBTransaction() override;
DECLARE_VIRTUAL_TRACE();
static WebIDBTransactionMode stringToMode(const String&);
@@ -96,15 +96,15 @@ public:
void onComplete();
// EventTarget
- virtual const AtomicString& interfaceName() const override;
- virtual ExecutionContext* executionContext() const override;
+ const AtomicString& interfaceName() const override;
+ ExecutionContext* executionContext() const override;
using EventTarget::dispatchEvent;
- virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;
+ bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;
// ActiveDOMObject
- virtual bool hasPendingActivity() const override;
- virtual void stop() override;
+ bool hasPendingActivity() const override;
+ void stop() override;
private:
IDBTransaction(ScriptState*, int64_t, const HashSet<String>&, WebIDBTransactionMode, IDBDatabase*, IDBOpenDBRequest*, const IDBDatabaseMetadata&);
« no previous file with comments | « Source/modules/indexeddb/IDBRequestTest.cpp ('k') | Source/modules/indexeddb/IDBTransactionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698