Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1993)

Unified Diff: Source/modules/indexeddb/IDBTransactionTest.cpp

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/indexeddb/IDBTransaction.h ('k') | Source/modules/indexeddb/IDBVersionChangeEvent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/indexeddb/IDBTransactionTest.cpp
diff --git a/Source/modules/indexeddb/IDBTransactionTest.cpp b/Source/modules/indexeddb/IDBTransactionTest.cpp
index a4fba2a8b8b0db082eaa24289d1f1bde32f14f23..102b99b5cbf9811443321a203d28f236d180be74 100644
--- a/Source/modules/indexeddb/IDBTransactionTest.cpp
+++ b/Source/modules/indexeddb/IDBTransactionTest.cpp
@@ -51,13 +51,13 @@ public:
{
}
- virtual void SetUp() override
+ void SetUp() override
{
m_executionContext = Document::create();
m_scope.scriptState()->setExecutionContext(m_executionContext.get());
}
- virtual void TearDown() override
+ void TearDown() override
{
m_executionContext->notifyContextDestroyed();
m_scope.scriptState()->setExecutionContext(nullptr);
@@ -81,9 +81,9 @@ class FakeWebIDBDatabase final : public WebIDBDatabase {
public:
static PassOwnPtr<FakeWebIDBDatabase> create() { return adoptPtr(new FakeWebIDBDatabase()); }
- virtual void commit(long long transactionId) override { }
- virtual void abort(long long transactionId) override { }
- virtual void close() override { }
+ void commit(long long transactionId) override { }
+ void abort(long long transactionId) override { }
+ void close() override { }
private:
FakeWebIDBDatabase() { }
@@ -92,10 +92,10 @@ private:
class FakeIDBDatabaseCallbacks final : public IDBDatabaseCallbacks {
public:
static FakeIDBDatabaseCallbacks* create() { return new FakeIDBDatabaseCallbacks(); }
- virtual void onVersionChange(int64_t oldVersion, int64_t newVersion) override { }
- virtual void onForcedClose() override { }
- virtual void onAbort(int64_t transactionId, DOMError* error) override { }
- virtual void onComplete(int64_t transactionId) override { }
+ void onVersionChange(int64_t oldVersion, int64_t newVersion) override { }
+ void onForcedClose() override { }
+ void onAbort(int64_t transactionId, DOMError* error) override { }
+ void onComplete(int64_t transactionId) override { }
private:
FakeIDBDatabaseCallbacks() { }
};
« no previous file with comments | « Source/modules/indexeddb/IDBTransaction.h ('k') | Source/modules/indexeddb/IDBVersionChangeEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698