Chromium Code Reviews Chromium Code Reviews
Issue
1227363006:
Virtualize EventDispatchMediator creation and cleanup calling. (Closed)
DescriptionVirtualize EventDispatchMediator creation and cleanup calling.
Create a virtual on Event that allows the creation of the mediator.
This avoids the if... if... if conditions in the dispatchEventInternal
in Node.cpp; we reduce from invoking a bunch of virtuals down to just
invoking one.
The mediator doesn't need to be passed into the scoped event anymore;
use this same construct to create the mediator.
Collapse all EventDispatcher::dispathEvent calls that are passed in a
mediator to calling dispathEvent directly. This is done so that the
trusted event will be set correctly based on these calls. This has
a side effect of forcing the mediator to be created correctly
for the events from javascript. For example
new FocusEvent("focus", {relatedTarget: document.body }) would have ended up
creating the default EventDispatcher mediator. Now it correctly
creates a FocusEventMediator.
Collapse 4 types of FocusEventMediators to 1; they all did the exact
same thing in different class names.
Make WheelEventMediator creation pattern consistent with the other
mediators.
Introduce isTrusted temporarily on MouseEvent. There was already synthetic
mouse behaviour when creating the mediator; collapse this into the
isTrusted support. The field & methods on MouseEvent will be removed
when the Event.isTrusted support is landed.
BUG=334015
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198997
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add TODO and rename variable #Patch Set 3 : Rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 8 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
