Add Event.isTrusted support

Add Event.isTrusted support

Add the Event.isTrusted support behind an TrustedEvents experimental
feature flag. The trusted flag is set at the point of event dispatch
just before any event processing on the event takes place.

There are 5 spots where the trusted events are set
1) EventTarget::eventDispatch (from C++)
2) EventTarget::eventDispatchForBindings (from JS)
3) LocalDOMWindow::dispatchEvent (from C++) with special semantics about target
4) SimulatedMouseEvent constructor (these events are generated
   by the EventDispatcher itself)
5) Node::dispatchScopedEvent

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/cEJvjWg9bqg

BUG=334015
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199071

[dtapuska, 2015-07-14 21:39:53]

dtapuska@chromium.org changed reviewers:
+ tkent@chromium.org

[dtapuska, 2015-07-14 21:42:22]

dtapuska@chromium.org changed reviewers:
+ yukishiino@chromium.org

[dtapuska, 2015-07-14 21:42:22]

+yukishiino

Not sure if this is the correct approach as I had to add the fact that there are
getters in the webexposed tests for the Unforgeable events where I didn't
require this before.

But adding 50+ TODOs with in each Event subclass seemed wrong to me.

[Yuki, 2015-07-15 06:17:52]

On 2015/07/14 21:42:22, Dave Tapuska wrote:
> +yukishiino
> 
> Not sure if this is the correct approach as I had to add the fact that there
are
> getters in the webexposed tests for the Unforgeable events where I didn't
> require this before.
> 
> But adding 50+ TODOs with in each Event subclass seemed wrong to me.

I sent a separate e-mail to Dave.  Please DO NOT drop [Unforgeable] for
Event.isTrusted because [Unforgeable] is critical for Event.isTrusted.  If it's
not [Unforgeable], Event.isTrusted is meaningless.

I'm sorry for the inconveniences, but I think you can workaround it by adding
Event.isTrusted to another exception in v8_attributes.cpp, as demonstrated at
https://codereview.chromium.org/1228373009/

[dtapuska, 2015-07-15 22:46:07]

On 2015/07/15 06:17:52, Yuki wrote:
> On 2015/07/14 21:42:22, Dave Tapuska wrote:
> > +yukishiino
> > 
> > Not sure if this is the correct approach as I had to add the fact that there
> are
> > getters in the webexposed tests for the Unforgeable events where I didn't
> > require this before.
> > 
> > But adding 50+ TODOs with in each Event subclass seemed wrong to me.
> 
> I sent a separate e-mail to Dave.  Please DO NOT drop [Unforgeable] for
> Event.isTrusted because [Unforgeable] is critical for Event.isTrusted.  If
it's
> not [Unforgeable], Event.isTrusted is meaningless.
> 
> I'm sorry for the inconveniences, but I think you can workaround it by adding
> Event.isTrusted to another exception in v8_attributes.cpp, as demonstrated at
> https://codereview.chromium.org/1228373009/

Thanks for the demonstration. Much appreciated.

[dtapuska, 2015-07-15 22:46:23]

On 2015/07/15 22:46:07, Dave Tapuska wrote:
> On 2015/07/15 06:17:52, Yuki wrote:
> > On 2015/07/14 21:42:22, Dave Tapuska wrote:
> > > +yukishiino
> > > 
> > > Not sure if this is the correct approach as I had to add the fact that
there
> > are
> > > getters in the webexposed tests for the Unforgeable events where I didn't
> > > require this before.
> > > 
> > > But adding 50+ TODOs with in each Event subclass seemed wrong to me.
> > 
> > I sent a separate e-mail to Dave.  Please DO NOT drop [Unforgeable] for
> > Event.isTrusted because [Unforgeable] is critical for Event.isTrusted.  If
> it's
> > not [Unforgeable], Event.isTrusted is meaningless.
> > 
> > I'm sorry for the inconveniences, but I think you can workaround it by
adding
> > Event.isTrusted to another exception in v8_attributes.cpp, as demonstrated
at
> > https://codereview.chromium.org/1228373009/
> 
> Thanks for the demonstration. Much appreciated.

PTAL

[tkent, 2015-07-16 03:29:37]

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/fast/events...
File LayoutTests/fast/events/event-trusted.html (right):

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/fast/events...
LayoutTests/fast/events/event-trusted.html:5: description("This tests that
isTrusted returns the correct value under certain situations.")
nit: should remove the top-level 4 space indentation.  It is not helpful.

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
File
LayoutTests/imported/web-platform-tests/html/editing/focus/focus-management/focus-events-expected.txt
(right):

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
LayoutTests/imported/web-platform-tests/html/editing/focus/focus-management/focus-events-expected.txt:1:
This is a testharness.js-based test.
Please remove this file.  testharness.js-based tests don't need successful
expectation files.

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
File
LayoutTests/imported/web-platform-tests/html/semantics/forms/textfieldselection/select-event-expected.txt
(right):

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
LayoutTests/imported/web-platform-tests/html/semantics/forms/textfieldselection/select-event-expected.txt:1:
This is a testharness.js-based test.
Remove this file.

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
File
LayoutTests/imported/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent-expected.txt
(right):

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
LayoutTests/imported/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent-expected.txt:1:
This is a testharness.js-based test.
Remove this file.

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
File
LayoutTests/imported/web-platform-tests/html/syntax/parsing/the-end-expected.txt
(right):

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
LayoutTests/imported/web-platform-tests/html/syntax/parsing/the-end-expected.txt:1:
This is a testharness.js-based test.
Remove this file.

https://codereview.chromium.org/1233233003/diff/20001/Source/core/events/Even...
File Source/core/events/Event.idl (right):

https://codereview.chromium.org/1233233003/diff/20001/Source/core/events/Even...
Source/core/events/Event.idl:46: [RuntimeEnabled=TrustedEvents, Unforgeable ]
readonly attribute boolean isTrusted;
nit: remove space before ]

[Yuki, 2015-07-16 05:09:33]

lgtm for bindings.

[dtapuska, 2015-07-16 14:48:22]

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/fast/events...
File LayoutTests/fast/events/event-trusted.html (right):

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/fast/events...
LayoutTests/fast/events/event-trusted.html:5: description("This tests that
isTrusted returns the correct value under certain situations.")
On 2015/07/16 03:29:37, tkent wrote:
> nit: should remove the top-level 4 space indentation.  It is not helpful.

Done.

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
File
LayoutTests/imported/web-platform-tests/html/editing/focus/focus-management/focus-events-expected.txt
(right):

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
LayoutTests/imported/web-platform-tests/html/editing/focus/focus-management/focus-events-expected.txt:1:
This is a testharness.js-based test.
On 2015/07/16 03:29:37, tkent wrote:
> Please remove this file.  testharness.js-based tests don't need successful
> expectation files.

Done.

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
File
LayoutTests/imported/web-platform-tests/html/semantics/forms/textfieldselection/select-event-expected.txt
(right):

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
LayoutTests/imported/web-platform-tests/html/semantics/forms/textfieldselection/select-event-expected.txt:1:
This is a testharness.js-based test.
On 2015/07/16 03:29:37, tkent wrote:
> Remove this file.

Done.

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
File
LayoutTests/imported/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent-expected.txt
(right):

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
LayoutTests/imported/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent-expected.txt:1:
This is a testharness.js-based test.
On 2015/07/16 03:29:37, tkent wrote:
> Remove this file.

Done.

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
File
LayoutTests/imported/web-platform-tests/html/syntax/parsing/the-end-expected.txt
(right):

https://codereview.chromium.org/1233233003/diff/20001/LayoutTests/imported/we...
LayoutTests/imported/web-platform-tests/html/syntax/parsing/the-end-expected.txt:1:
This is a testharness.js-based test.
On 2015/07/16 03:29:37, tkent wrote:
> Remove this file.

Done.

https://codereview.chromium.org/1233233003/diff/20001/Source/core/events/Even...
File Source/core/events/Event.idl (right):

https://codereview.chromium.org/1233233003/diff/20001/Source/core/events/Even...
Source/core/events/Event.idl:46: [RuntimeEnabled=TrustedEvents, Unforgeable ]
readonly attribute boolean isTrusted;
On 2015/07/16 03:29:37, tkent wrote:
> nit: remove space before ]

Done.

[tkent, 2015-07-16 23:33:32]

The CQ bit was checked by tkent@chromium.org

[tkent, 2015-07-16 23:33:32]

lgtm

[tkent, 2015-07-16 23:33:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/1233233003/#ps40001
(title: "Fix nits")

[commit-bot: I haz the power, 2015-07-16 23:34:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1233233003/40001

[commit-bot: I haz the power, 2015-07-17 01:33:04]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199071