Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1227353005: Cleanup changes: Rename QuicSession::MarkWriteBlocked to (Closed)

Created:
5 years, 5 months ago by ramant (doing other things)
Modified:
5 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup changes: Rename QuicSession::MarkWriteBlocked to QuicSession::MarkConnectionLevelWriteBlocked. Replace "> >" with ">>". Put #includes in proper order. Log a StringPiece correctly. Change "virtual" to "override" where clang_tidy objects. Name a temporary object. Add braces around "for" loops. clang-format changes. Merge internal change: 97160447 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -80 lines) Patch
M net/quic/crypto/crypto_framer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/crypto_framer.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 4 chunks +11 lines, -14 lines 0 comments Download
M net/quic/crypto/strike_register.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/strike_register.cc View 4 chunks +13 lines, -12 lines 0 comments Download
M net/quic/crypto/strike_register_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_received_packet_manager_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_reliable_client_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/quic_session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_session_test.cc View 10 chunks +35 lines, -31 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/reliable_quic_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
5 years, 5 months ago (2015-07-16 22:31:20 UTC) #1
Ryan Hamilton
5 years, 5 months ago (2015-07-16 22:48:29 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698