Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: net/quic/quic_session_test.cc

Issue 1227353005: Cleanup changes: Rename QuicSession::MarkWriteBlocked to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/quic/quic_stream_sequencer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_session_test.cc
diff --git a/net/quic/quic_session_test.cc b/net/quic/quic_session_test.cc
index 672ecf800f4361b55ec81415685d40a0a09a30bf..389952bf0b4e06d89ece1505b270920f538cb32c 100644
--- a/net/quic/quic_session_test.cc
+++ b/net/quic/quic_session_test.cc
@@ -109,8 +109,8 @@ class StreamBlocker {
stream_id_(stream_id) {
}
- void MarkWriteBlocked() {
- session_->MarkWriteBlocked(stream_id_, kSomeMiddlePriority);
+ void MarkConnectionLevelWriteBlocked() {
+ session_->MarkConnectionLevelWriteBlocked(stream_id_, kSomeMiddlePriority);
}
private:
@@ -327,9 +327,9 @@ TEST_P(QuicSessionTestServer, DebugDFatalIfMarkingClosedStreamWriteBlocked) {
// Close the stream.
EXPECT_CALL(*connection_, SendRstStream(kClosedStreamId, _, _));
stream2->Reset(QUIC_BAD_APPLICATION_PAYLOAD);
- EXPECT_DEBUG_DFATAL(
- session_.MarkWriteBlocked(kClosedStreamId, kSomeMiddlePriority),
- "Marking unknown stream 2 blocked.");
+ EXPECT_DEBUG_DFATAL(session_.MarkConnectionLevelWriteBlocked(
+ kClosedStreamId, kSomeMiddlePriority),
+ "Marking unknown stream 2 blocked.");
}
TEST_P(QuicSessionTestServer,
@@ -338,9 +338,9 @@ TEST_P(QuicSessionTestServer,
TestStream* stream2 = session_.CreateOutgoingDynamicStream();
EXPECT_NE(kDifferentPriority, stream2->EffectivePriority());
- EXPECT_DEBUG_DFATAL(
- session_.MarkWriteBlocked(stream2->id(), kDifferentPriority),
- "Priorities do not match. Got: 0 Expected: 3");
+ EXPECT_DEBUG_DFATAL(session_.MarkConnectionLevelWriteBlocked(
+ stream2->id(), kDifferentPriority),
+ "Priorities do not match. Got: 0 Expected: 3");
}
TEST_P(QuicSessionTestServer, OnCanWrite) {
@@ -348,15 +348,16 @@ TEST_P(QuicSessionTestServer, OnCanWrite) {
TestStream* stream4 = session_.CreateOutgoingDynamicStream();
TestStream* stream6 = session_.CreateOutgoingDynamicStream();
- session_.MarkWriteBlocked(stream2->id(), kSomeMiddlePriority);
- session_.MarkWriteBlocked(stream6->id(), kSomeMiddlePriority);
- session_.MarkWriteBlocked(stream4->id(), kSomeMiddlePriority);
+ session_.MarkConnectionLevelWriteBlocked(stream2->id(), kSomeMiddlePriority);
+ session_.MarkConnectionLevelWriteBlocked(stream6->id(), kSomeMiddlePriority);
+ session_.MarkConnectionLevelWriteBlocked(stream4->id(), kSomeMiddlePriority);
InSequence s;
StreamBlocker stream2_blocker(&session_, stream2->id());
// Reregister, to test the loop limit.
EXPECT_CALL(*stream2, OnCanWrite())
- .WillOnce(Invoke(&stream2_blocker, &StreamBlocker::MarkWriteBlocked));
+ .WillOnce(Invoke(&stream2_blocker,
+ &StreamBlocker::MarkConnectionLevelWriteBlocked));
EXPECT_CALL(*stream6, OnCanWrite());
EXPECT_CALL(*stream4, OnCanWrite());
session_.OnCanWrite();
@@ -372,9 +373,9 @@ TEST_P(QuicSessionTestServer, OnCanWriteBundlesStreams) {
TestStream* stream4 = session_.CreateOutgoingDynamicStream();
TestStream* stream6 = session_.CreateOutgoingDynamicStream();
- session_.MarkWriteBlocked(stream2->id(), kSomeMiddlePriority);
- session_.MarkWriteBlocked(stream6->id(), kSomeMiddlePriority);
- session_.MarkWriteBlocked(stream4->id(), kSomeMiddlePriority);
+ session_.MarkConnectionLevelWriteBlocked(stream2->id(), kSomeMiddlePriority);
+ session_.MarkConnectionLevelWriteBlocked(stream6->id(), kSomeMiddlePriority);
+ session_.MarkConnectionLevelWriteBlocked(stream4->id(), kSomeMiddlePriority);
EXPECT_CALL(*send_algorithm, TimeUntilSend(_, _, _)).WillRepeatedly(
Return(QuicTime::Delta::Zero()));
@@ -413,9 +414,9 @@ TEST_P(QuicSessionTestServer, OnCanWriteCongestionControlBlocks) {
TestStream* stream4 = session_.CreateOutgoingDynamicStream();
TestStream* stream6 = session_.CreateOutgoingDynamicStream();
- session_.MarkWriteBlocked(stream2->id(), kSomeMiddlePriority);
- session_.MarkWriteBlocked(stream6->id(), kSomeMiddlePriority);
- session_.MarkWriteBlocked(stream4->id(), kSomeMiddlePriority);
+ session_.MarkConnectionLevelWriteBlocked(stream2->id(), kSomeMiddlePriority);
+ session_.MarkConnectionLevelWriteBlocked(stream6->id(), kSomeMiddlePriority);
+ session_.MarkConnectionLevelWriteBlocked(stream4->id(), kSomeMiddlePriority);
StreamBlocker stream2_blocker(&session_, stream2->id());
EXPECT_CALL(*send_algorithm, TimeUntilSend(_, _, _)).WillOnce(Return(
@@ -452,21 +453,21 @@ TEST_P(QuicSessionTestServer, BufferedHandshake) {
// Test that blocking other streams does not change our status.
TestStream* stream2 = session_.CreateOutgoingDynamicStream();
StreamBlocker stream2_blocker(&session_, stream2->id());
- stream2_blocker.MarkWriteBlocked();
+ stream2_blocker.MarkConnectionLevelWriteBlocked();
EXPECT_FALSE(session_.HasPendingHandshake());
TestStream* stream3 = session_.CreateOutgoingDynamicStream();
StreamBlocker stream3_blocker(&session_, stream3->id());
- stream3_blocker.MarkWriteBlocked();
+ stream3_blocker.MarkConnectionLevelWriteBlocked();
EXPECT_FALSE(session_.HasPendingHandshake());
// Blocking (due to buffering of) the Crypto stream is detected.
- session_.MarkWriteBlocked(kCryptoStreamId, kHighestPriority);
+ session_.MarkConnectionLevelWriteBlocked(kCryptoStreamId, kHighestPriority);
EXPECT_TRUE(session_.HasPendingHandshake());
TestStream* stream4 = session_.CreateOutgoingDynamicStream();
StreamBlocker stream4_blocker(&session_, stream4->id());
- stream4_blocker.MarkWriteBlocked();
+ stream4_blocker.MarkConnectionLevelWriteBlocked();
EXPECT_TRUE(session_.HasPendingHandshake());
InSequence s;
@@ -481,11 +482,14 @@ TEST_P(QuicSessionTestServer, BufferedHandshake) {
// Re-register all other streams, to show they weren't able to proceed.
EXPECT_CALL(*stream2, OnCanWrite())
- .WillOnce(Invoke(&stream2_blocker, &StreamBlocker::MarkWriteBlocked));
+ .WillOnce(Invoke(&stream2_blocker,
+ &StreamBlocker::MarkConnectionLevelWriteBlocked));
EXPECT_CALL(*stream3, OnCanWrite())
- .WillOnce(Invoke(&stream3_blocker, &StreamBlocker::MarkWriteBlocked));
+ .WillOnce(Invoke(&stream3_blocker,
+ &StreamBlocker::MarkConnectionLevelWriteBlocked));
EXPECT_CALL(*stream4, OnCanWrite())
- .WillOnce(Invoke(&stream4_blocker, &StreamBlocker::MarkWriteBlocked));
+ .WillOnce(Invoke(&stream4_blocker,
+ &StreamBlocker::MarkConnectionLevelWriteBlocked));
session_.OnCanWrite();
EXPECT_TRUE(session_.WillingAndAbleToWrite());
@@ -497,9 +501,9 @@ TEST_P(QuicSessionTestServer, OnCanWriteWithClosedStream) {
TestStream* stream4 = session_.CreateOutgoingDynamicStream();
TestStream* stream6 = session_.CreateOutgoingDynamicStream();
- session_.MarkWriteBlocked(stream2->id(), kSomeMiddlePriority);
- session_.MarkWriteBlocked(stream6->id(), kSomeMiddlePriority);
- session_.MarkWriteBlocked(stream4->id(), kSomeMiddlePriority);
+ session_.MarkConnectionLevelWriteBlocked(stream2->id(), kSomeMiddlePriority);
+ session_.MarkConnectionLevelWriteBlocked(stream6->id(), kSomeMiddlePriority);
+ session_.MarkConnectionLevelWriteBlocked(stream4->id(), kSomeMiddlePriority);
CloseStream(stream6->id());
InSequence s;
@@ -518,13 +522,13 @@ TEST_P(QuicSessionTestServer, OnCanWriteLimitsNumWritesIfFlowControlBlocked) {
// Mark the crypto and headers streams as write blocked, we expect them to be
// allowed to write later.
- session_.MarkWriteBlocked(kCryptoStreamId, kHighestPriority);
- session_.MarkWriteBlocked(kHeadersStreamId, kHighestPriority);
+ session_.MarkConnectionLevelWriteBlocked(kCryptoStreamId, kHighestPriority);
+ session_.MarkConnectionLevelWriteBlocked(kHeadersStreamId, kHighestPriority);
// Create a data stream, and although it is write blocked we never expect it
// to be allowed to write as we are connection level flow control blocked.
TestStream* stream = session_.CreateOutgoingDynamicStream();
- session_.MarkWriteBlocked(stream->id(), kSomeMiddlePriority);
+ session_.MarkConnectionLevelWriteBlocked(stream->id(), kSomeMiddlePriority);
EXPECT_CALL(*stream, OnCanWrite()).Times(0);
// The crypto and headers streams should be called even though we are
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/quic/quic_stream_sequencer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698