go/src/infra/gae/libs/gae/memory/plist.go - Issue 1227183003: Change RawDatastore to do less reflection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: go/src/infra/gae/libs/gae/memory/plist.go

Issue 1227183003: Change RawDatastore to do less reflection. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@move_dummy

Patch Set: fix No/ShouldIndex Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: go/src/infra/gae/libs/gae/memory/plist.go

diff --git a/go/src/infra/gae/libs/gae/memory/plist.go b/go/src/infra/gae/libs/gae/memory/plist.go

index 09cfec514c826f817a271b01f121500a6147b22a..13f9bc8b9511006ebd0fb600ec2c78a282244415 100644

--- a/go/src/infra/gae/libs/gae/memory/plist.go

+++ b/go/src/infra/gae/libs/gae/memory/plist.go

@@ -29,7 +29,7 @@ func defaultIndicies(kind string, pmap gae.DSPropertyMap) []*qIndex {

for name, pvals := range pmap {

needsIndex := false

for _, v := range pvals {

- if !v.NoIndex() {

+ if v.IndexSetting() == gae.ShouldIndex {

needsIndex = true

break

}

@@ -71,7 +71,7 @@ func partiallySerialize(pm gae.DSPropertyMap) (ret serializedIndexablePmap) {

for k, vals := range pm {

newVals := make(serializedPvals, 0, len(vals))

for _, v := range vals {

- if v.NoIndex() {

+ if v.IndexSetting() == gae.NoIndex {

continue

}

buf.Reset()