Change RawDatastore to do less reflection.

go/src/infra/gae/libs/gae/memory/plist.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package memory
 
 import (
         "bytes"
         "fmt"
         "sort"
@@ skipping 11 matching lines @@
 func (s qIndexSlice) Len() int           { return len(s) }
 func (s qIndexSlice) Swap(i, j int)      { s[i], s[j] = s[j], s[i] }
 func (s qIndexSlice) Less(i, j int) bool { return s[i].Less(s[j]) }
 
 func defaultIndicies(kind string, pmap gae.DSPropertyMap) []*qIndex {
         ret := make(qIndexSlice, 0, 2*len(pmap)+1)
         ret = append(ret, &qIndex{kind, false, nil})
         for name, pvals := range pmap {
                 needsIndex := false
                 for _, v := range pvals {
-                        if !v.NoIndex() {
+                        if v.IndexSetting() == gae.ShouldIndex {
                                 needsIndex = true
                                 break
                         }
                 }
                 if !needsIndex {
                         continue
                 }
                 ret = append(ret, &qIndex{kind, false, []qSortBy{{name, qASC}}})
                 ret = append(ret, &qIndex{kind, false, []qSortBy{{name, qDEC}}})
         }
@@ skipping 21 matching lines @@
 func partiallySerialize(pm gae.DSPropertyMap) (ret serializedIndexablePmap) {
         if len(pm) == 0 {
                 return
         }
 
         buf := &bytes.Buffer{}
         ret = make(serializedIndexablePmap, len(pm))
         for k, vals := range pm {
                 newVals := make(serializedPvals, 0, len(vals))
                 for _, v := range vals {
-                        if v.NoIndex() {
+                        if v.IndexSetting() == gae.NoIndex {
                                 continue
                         }
                         buf.Reset()
                         helper.WriteDSProperty(buf, v, helper.WithoutContext)
                         newVal := make([]byte, buf.Len())
                         copy(newVal, buf.Bytes())
                         newVals = append(newVals, newVal)
                 }
                 if len(newVals) > 0 {
                         sort.Sort(newVals)
@@ skipping 204 matching lines @@
                         })
                 default:
                         panic("impossible")
                 }
                 // TODO(riannucci): remove entries from idxColl and remove index collections
                 // when there are no index entries for that index any more.
         })
 
         return nil
 }