tools/metrics/histograms/histograms.xml - Issue 1227173006: New SSL metric added: Likely From Same Domain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1227173006: New SSL metric added: Likely From Same Domain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolving comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 86071992c1731eab7bf35a0ae8a3aa691548f114..1b840ce5ef7d5455277ef2520b96f4bf14c0ae15 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -68276,6 +68276,13 @@ To add a new entry, add it with any value and run test to compute valid value.

</int>

+ <int value="13"

+ label="LIKELY_SAME_DOMAIN: Cert likely belongs to the same domain">

+ This case is recorded if the SSL error is CERT_COMMON_NAME_INVALID error and

+ the hostname in request URL has the same domain (effective TLD + 1 label) as

+ the common name or at least one of the subject alternative names in

+ certificate. This case is not recorded if the host name is not a known tld.

+ </int>

</enum>

« no previous file with comments | « chrome/browser/ssl/ssl_error_classification_unittest.cc ('k') | no next file » | no next file with comments »