Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: chrome/browser/ssl/ssl_error_classification_unittest.cc

Issue 1227173006: New SSL metric added: Likely From Same Domain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: resolving comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/ssl_error_classification.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_error_classification_unittest.cc
diff --git a/chrome/browser/ssl/ssl_error_classification_unittest.cc b/chrome/browser/ssl/ssl_error_classification_unittest.cc
index 593afdebff5bdf1b56b4511ba33f93ee512b5e0c..c052a4faf03397b39a1cfa88535cb43a3c2be2df 100644
--- a/chrome/browser/ssl/ssl_error_classification_unittest.cc
+++ b/chrome/browser/ssl/ssl_error_classification_unittest.cc
@@ -59,6 +59,7 @@ TEST_F(SSLErrorClassificationTest, TestNameMismatch) {
host_name_tokens));
EXPECT_FALSE(ssl_error.IsSubDomainOutsideWildcard(host_name_tokens));
EXPECT_FALSE(ssl_error.IsCertLikelyFromMultiTenantHosting());
+ EXPECT_TRUE(ssl_error.IsCertLikelyFromSameDomain());
}
{
@@ -76,6 +77,7 @@ TEST_F(SSLErrorClassificationTest, TestNameMismatch) {
dns_name_tokens_google));
EXPECT_FALSE(ssl_error.AnyNamesUnderName(dns_name_tokens_google,
host_name_tokens));
+ EXPECT_TRUE(ssl_error.IsCertLikelyFromSameDomain());
}
{
@@ -93,6 +95,7 @@ TEST_F(SSLErrorClassificationTest, TestNameMismatch) {
dns_name_tokens_google));
EXPECT_FALSE(ssl_error.AnyNamesUnderName(dns_name_tokens_google,
host_name_tokens));
+ EXPECT_TRUE(ssl_error.IsCertLikelyFromSameDomain());
}
{
@@ -110,6 +113,7 @@ TEST_F(SSLErrorClassificationTest, TestNameMismatch) {
dns_name_tokens_google));
EXPECT_FALSE(ssl_error.AnyNamesUnderName(dns_name_tokens_google,
host_name_tokens));
+ EXPECT_FALSE(ssl_error.IsCertLikelyFromSameDomain());
}
{
@@ -127,6 +131,7 @@ TEST_F(SSLErrorClassificationTest, TestNameMismatch) {
dns_name_tokens_google));
EXPECT_FALSE(ssl_error.AnyNamesUnderName(dns_name_tokens_google,
host_name_tokens));
+ EXPECT_FALSE(ssl_error.IsCertLikelyFromSameDomain());
}
scoped_refptr<net::X509Certificate> webkit_cert(
@@ -155,6 +160,7 @@ TEST_F(SSLErrorClassificationTest, TestNameMismatch) {
host_name_tokens));
EXPECT_TRUE(ssl_error.IsSubDomainOutsideWildcard(host_name_tokens));
EXPECT_FALSE(ssl_error.IsCertLikelyFromMultiTenantHosting());
+ EXPECT_TRUE(ssl_error.IsCertLikelyFromSameDomain());
}
}
« no previous file with comments | « chrome/browser/ssl/ssl_error_classification.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698