Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 1227173002: Reland third_party/libwebm (Closed)

Created:
5 years, 5 months ago by mcasas
Modified:
5 years, 5 months ago
Reviewers:
emircan, brettw, jam, Tom Finegan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland third_party/libwebm The starting point is smart-extracted from https://codereview.chromium.org/820593002 and is to be used for MediaStream Recording API, see bug and/or DD https://goo.gl/kreaQj BUG=262211 Committed: https://crrev.com/09903b31ee8a9bf3dfbac6ceb21452c969025071 Cr-Commit-Position: refs/heads/master@{#338700}

Patch Set 1 : Relanded extracted patch from https://codereview.chromium.org/820593002 #

Patch Set 2 : Removed gyp/gn special treatment and updated version and OWNERS. #

Total comments: 1

Patch Set 3 : README.chromium update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/libwebm/BUILD.gn View 1 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/libwebm/OWNERS View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/libwebm/README.chromium View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/libwebm/libwebm.gyp View 1 1 chunk +17 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (9 generated)
mcasas
emircan@, tomfinegan@ PTAL
5 years, 5 months ago (2015-07-10 00:42:13 UTC) #5
Tom Finegan
lgtm % readme comment I don't think my lgtm will allow creation of a third_party/ ...
5 years, 5 months ago (2015-07-10 01:32:34 UTC) #6
emircan
lgtm
5 years, 5 months ago (2015-07-10 16:52:57 UTC) #7
mcasas
jam@ OWNERS RS/PTAL/Fwd appropriately plz :)
5 years, 5 months ago (2015-07-10 17:11:03 UTC) #9
mcasas
jam@ --> brettw@ PTAL/Owners RS plz
5 years, 5 months ago (2015-07-10 23:05:55 UTC) #11
jam
lgtm
5 years, 5 months ago (2015-07-14 14:40:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227173002/100001
5 years, 5 months ago (2015-07-14 15:17:17 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:100001)
5 years, 5 months ago (2015-07-14 16:20:55 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 16:22:05 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/09903b31ee8a9bf3dfbac6ceb21452c969025071
Cr-Commit-Position: refs/heads/master@{#338700}

Powered by Google App Engine
This is Rietveld 408576698