Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2162)

Issue 820593002: remove libwebm third_party dependency (Closed)

Created:
6 years ago by Sergey Ulanov
Modified:
6 years ago
Reviewers:
brettw
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove libwebm third_party dependency. libwebm was used in remoting, but is not needed anymore. Committed: https://crrev.com/c053fb4fec709c4a5a72065305ee4eb2da2efaa8 Cr-Commit-Position: refs/heads/master@{#309243} Committed: https://crrev.com/93761d507b748c31730eb86ad5fd6e16d5d459af Cr-Commit-Position: refs/heads/master@{#309295}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -114 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/client/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D remoting/client/plugin/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/remoting_client.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting_nacl.gyp View 1 2 4 chunks +0 lines, -4 lines 0 comments Download
D third_party/libwebm/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/libwebm/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/libwebm/README.chromium View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/libwebm/libwebm.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/libwebm/libwebm.gypi View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/libwebm/libwebm_nacl.gyp View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Sergey Ulanov
6 years ago (2014-12-19 01:09:09 UTC) #2
brettw
lgtm
6 years ago (2014-12-19 18:16:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820593002/1
6 years ago (2014-12-19 18:26:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/28017)
6 years ago (2014-12-19 18:33:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820593002/20001
6 years ago (2014-12-19 18:44:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-19 20:08:38 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c053fb4fec709c4a5a72065305ee4eb2da2efaa8 Cr-Commit-Position: refs/heads/master@{#309243}
6 years ago (2014-12-19 20:09:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820593002/40001
6 years ago (2014-12-19 22:03:10 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-19 23:39:25 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-19 23:40:19 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/93761d507b748c31730eb86ad5fd6e16d5d459af
Cr-Commit-Position: refs/heads/master@{#309295}

Powered by Google App Engine
This is Rietveld 408576698