chrome/browser/extensions/events_apitest.cc - Issue 1227093008: Clear an extension's filtered events when a context is destroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/events_apitest.cc

Issue 1227093008: Clear an extension's filtered events when a context is destroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/events_are_unregistered/manifest.json » ('j') | chrome/test/data/extensions/api_test/events_are_unregistered/page1.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/events_apitest.cc

diff --git a/chrome/browser/extensions/events_apitest.cc b/chrome/browser/extensions/events_apitest.cc

index 6184bb6b28452638bfb38e901ed74f2aab9cd40e..7997663471a533ac2faa99055654b88c846a2b0d 100644

--- a/chrome/browser/extensions/events_apitest.cc

+++ b/chrome/browser/extensions/events_apitest.cc

@@ -54,6 +54,15 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, EventsAreUnregistered) {

event_router->ExtensionHasEventListener(id, "runtime.onSuspend"));

EXPECT_FALSE(

event_router->ExtensionHasEventListener(id, "runtime.onInstalled"));

+ // A filtered event.

Devlin 2015/07/10 17:57:30 This comment seems incomplete.

not at google - send to devlin 2015/07/10 20:39:16 Done.

+ EXPECT_FALSE(event_router->ExtensionHasEventListener(

+ id, "webNavigation.onBeforeNavigate"));

+ EXPECT_FALSE(

+ event_router->ExtensionHasEventListener(id, "webNavigation.onCommitted"));

+ EXPECT_FALSE(event_router->ExtensionHasEventListener(

+ id, "webNavigation.onDOMContentLoaded"));

+ EXPECT_FALSE(

+ event_router->ExtensionHasEventListener(id, "webNavigation.onCompleted"));

}

} // namespace extensions