chrome/browser/extensions/events_apitest.cc - Issue 1227093008: Clear an extension's filtered events when a context is destroyed.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/events_apitest.cc

Issue 1227093008: Clear an extension's filtered events when a context is destroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/events_are_unregistered/manifest.json » ('j') | chrome/test/data/extensions/api_test/events_are_unregistered/page1.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/files/file_path.h"	5 #include "base/files/file_path.h"

6 #include "base/files/file_util.h"	6 #include "base/files/file_util.h"

7 #include "chrome/browser/extensions/extension_apitest.h"	7 #include "chrome/browser/extensions/extension_apitest.h"

8 #include "extensions/browser/event_router.h"	8 #include "extensions/browser/event_router.h"

9 #include "extensions/browser/extension_registry.h"	9 #include "extensions/browser/extension_registry.h"

10	10

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47 // The page has closed, so no matter what all events are no longer listened	47 // The page has closed, so no matter what all events are no longer listened

48 // to.	48 // to.

49 EXPECT_FALSE(	49 EXPECT_FALSE(

50 event_router->ExtensionHasEventListener(id, "browserAction.onClicked"));	50 event_router->ExtensionHasEventListener(id, "browserAction.onClicked"));

51 EXPECT_FALSE(	51 EXPECT_FALSE(

52 event_router->ExtensionHasEventListener(id, "runtime.onStartup"));	52 event_router->ExtensionHasEventListener(id, "runtime.onStartup"));

53 EXPECT_FALSE(	53 EXPECT_FALSE(

54 event_router->ExtensionHasEventListener(id, "runtime.onSuspend"));	54 event_router->ExtensionHasEventListener(id, "runtime.onSuspend"));

55 EXPECT_FALSE(	55 EXPECT_FALSE(

56 event_router->ExtensionHasEventListener(id, "runtime.onInstalled"));	56 event_router->ExtensionHasEventListener(id, "runtime.onInstalled"));

	57 // A filtered event.
	Devlin 2015/07/10 17:57:30 This comment seems incomplete. This comment seems incomplete. not at google - send to devlin 2015/07/10 20:39:16 Done. Show quoted text On 2015/07/10 17:57:30, Devlin wrote: > This comment seems incomplete. Done.
	58 EXPECT_FALSE(event_router->ExtensionHasEventListener(

	59 id, "webNavigation.onBeforeNavigate"));

	60 EXPECT_FALSE(

	61 event_router->ExtensionHasEventListener(id, "webNavigation.onCommitted"));

	62 EXPECT_FALSE(event_router->ExtensionHasEventListener(

	63 id, "webNavigation.onDOMContentLoaded"));

	64 EXPECT_FALSE(

	65 event_router->ExtensionHasEventListener(id, "webNavigation.onCompleted"));

57 }	66 }

58	67

59 } // namespace extensions	68 } // namespace extensions

OLD	NEW