Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/libxml/libxml.gyp

Issue 1226583002: clang/win: Build chromium code without -Wno-incompatible-pointer-types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-logical-op-parentheses
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/libwebp/libwebp.gyp ('K') | « third_party/libxml/BUILD.gn ('k') | third_party/mesa/BUILD.gn » ('j') | third_party/zlib/zlib.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libxml/libxml.gyp
diff --git a/third_party/libxml/libxml.gyp b/third_party/libxml/libxml.gyp
index 79b3e1cc5b1dc5927422126e8115c6b152d0afc0..584bba8d4a7b29dd52e40d037c70e82b18bd38c0 100644
--- a/third_party/libxml/libxml.gyp
+++ b/third_party/libxml/libxml.gyp
@@ -214,6 +214,9 @@
'-Wno-ignored-attributes',
# libxml casts from int to long to void*.
'-Wno-int-to-void-pointer-cast',
+ # libxml passes a volatile LPCRITICAL_SECTION* to a function
+ # expecting a void* volatile*.
+ '-Wno-incompatible-pointer-types',
],
},
'include_dirs': [
« third_party/libwebp/libwebp.gyp ('K') | « third_party/libxml/BUILD.gn ('k') | third_party/mesa/BUILD.gn » ('j') | third_party/zlib/zlib.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698