Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: third_party/libxml/BUILD.gn

Issue 1226583002: clang/win: Build chromium code without -Wno-incompatible-pointer-types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-logical-op-parentheses
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libxml/BUILD.gn
diff --git a/third_party/libxml/BUILD.gn b/third_party/libxml/BUILD.gn
index bca823a89c33bb8acf04aa3f3c528cd7104c7755..1f10dee5889d545ecb672337e083253c172e51bb 100644
--- a/third_party/libxml/BUILD.gn
+++ b/third_party/libxml/BUILD.gn
@@ -187,6 +187,10 @@ static_library("libxml") {
cflags += [
# libxml casts from int to long to void*.
"-Wno-int-to-void-pointer-cast",
+
+ # libxml passes a volatile LPCRITICAL_SECTION* to a function expecting
+ # a void* volatile*.
+ "-Wno-incompatible-pointer-types",
]
}
}

Powered by Google App Engine
This is Rietveld 408576698