Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/libxml/BUILD.gn

Issue 1226583002: clang/win: Build chromium code without -Wno-incompatible-pointer-types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-logical-op-parentheses
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Define an "os_include" variable that points at the OS-specific generated 5 # Define an "os_include" variable that points at the OS-specific generated
6 # headers. These were generated by running the configure script offline. 6 # headers. These were generated by running the configure script offline.
7 if (is_linux || is_android || is_nacl) { 7 if (is_linux || is_android || is_nacl) {
8 os_include = "linux" 8 os_include = "linux"
9 } else if (is_mac || is_ios) { 9 } else if (is_mac || is_ios) {
10 os_include = "mac" 10 os_include = "mac"
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 # threads.c attempts to forward declare a pthread_equal which doesn't 180 # threads.c attempts to forward declare a pthread_equal which doesn't
181 # match the prototype in pthreads.h 181 # match the prototype in pthreads.h
182 "-Wno-ignored-attributes", 182 "-Wno-ignored-attributes",
183 ] 183 ]
184 } 184 }
185 config("libxml_warnings") { 185 config("libxml_warnings") {
186 if (is_clang) { 186 if (is_clang) {
187 cflags += [ 187 cflags += [
188 # libxml casts from int to long to void*. 188 # libxml casts from int to long to void*.
189 "-Wno-int-to-void-pointer-cast", 189 "-Wno-int-to-void-pointer-cast",
190
191 # libxml passes a volatile LPCRITICAL_SECTION* to a function expecting
192 # a void* volatile*.
193 "-Wno-incompatible-pointer-types",
190 ] 194 ]
191 } 195 }
192 } 196 }
193 configs += [ ":libxml_warnings" ] 197 configs += [ ":libxml_warnings" ]
194 198
195 include_dirs = [ "$os_include" ] 199 include_dirs = [ "$os_include" ]
196 } 200 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698