Clang on Windows: Remove -Wno-unused-variable.

Clang on Windows: Remove -Wno-unused-variable.

Unused variables are now errors. However, since lots of third-party code
has unused variables, added a blanket suppression to all third-party
code.

BUG=505319
Committed: https://crrev.com/3371ccbd9d83e1031c5891520e88acbc9c1859a0
Cr-Commit-Position: refs/heads/master@{#338242}

[Matt Giuca, 2015-07-03 04:04:36]

mgiuca@chromium.org changed reviewers:
+ garykac@chromium.org, thakis@chromium.org

[Matt Giuca, 2015-07-03 04:04:37]

garykac@chromium.org: Please review changes in remoting.

thakis@chromium.org: Please review changes in general build scripts.

Note: This is blocked on many other CLs:
- https://codereview.chromium.org/1212173003
- https://codereview.chromium.org/1220133003
- https://codereview.chromium.org/1214163009
- https://codereview.webrtc.org/1214713005
- Blink and WebRTC rolls.

[Nico, 2015-07-03 04:12:41]

lgtm

[garykac, 2015-07-03 16:09:41]

lgtm

[Nico, 2015-07-09 18:57:19]

can this land?

[Matt Giuca, 2015-07-10 00:18:13]

Still need to do a WebRTC roll. I'll mail one out now.

[Matt Giuca, 2015-07-10 00:49:15]

Wait... my patch *was* already rolled into WebRTC in r338015. Sorry for the
mixup. Yes this should be landable now.

[Matt Giuca, 2015-07-10 00:49:22]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[Matt Giuca, 2015-07-10 00:50:35]

The CQ bit was unchecked by mgiuca@chromium.org

[Matt Giuca, 2015-07-10 00:50:40]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-07-10 00:52:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1226573002/1

[commit-bot: I haz the power, 2015-07-10 00:56:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-10 00:56:40]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

(exceeded global retry quota)

[Nico, 2015-07-10 01:04:09]

That looks like it's just "patch failure" after clicking through – rebasing
should be enough.

On Thu, Jul 9, 2015 at 5:56 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Try jobs failed on following builders:
>   linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
>
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
> )
>   ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
>
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...
> )
>   ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
>
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...
> )
>   mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
>
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...
> )
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...
> )
>   win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
>
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...
> )
>
> (exceeded global retry quota)
>
> https://codereview.chromium.org/1226573002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Matt Giuca, 2015-07-10 03:17:59]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2015-07-10 03:18:00]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
garykac@chromium.org
Link to the patchset: https://codereview.chromium.org/1226573002/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-07-10 03:18:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1226573002/20001

[commit-bot: I haz the power, 2015-07-10 03:23:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-10 03:23:52]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

(exceeded global retry quota)

[Nico, 2015-07-10 03:31:31]

https://codereview.chromium.org/1226573002/diff/20001/remoting/remoting_host_...
File remoting/remoting_host_win.gypi (right):

https://codereview.chromium.org/1226573002/diff/20001/remoting/remoting_host_...
remoting/remoting_host_win.gypi:104: '-Wno-incompatible-pointer-types',
gyp: Key 'variables' repeated at level 3 with key path 'targets.2' while reading
/b/build/slave/android/build/src/remoting/remoting_host_win.gypi while reading
includes of /b/build/slave/android/build/src/remoting/remoting_host.gypi while
reading includes of /b/build/slave/android/build/src/remoting/remoting.gyp


aha, add the flag here instead of duplicating the variables block

[Matt Giuca, 2015-07-10 03:36:45]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2015-07-10 03:36:45]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
garykac@chromium.org
Link to the patchset: https://codereview.chromium.org/1226573002/#ps40001
(title: "Avoid duplicate variables block.")

[commit-bot: I haz the power, 2015-07-10 03:37:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1226573002/40001

[commit-bot: I haz the power, 2015-07-10 04:55:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-10 04:56:03]

Patchset 3 (id:??) landed as
https://crrev.com/3371ccbd9d83e1031c5891520e88acbc9c1859a0
Cr-Commit-Position: refs/heads/master@{#338242}

[Matt Giuca, 2015-07-10 07:51:26]

Hmm, accordingn to http://crbug.com/505319#c30, there are a few warnings still.
I'm not sure why I didn't pick them up (maybe the code changed since I synced,
or maybe it isn't building those targets on my machine).

To keep the Clang bots building, I'll revert this now and re-land after the fix
(which will be after branch point too).

[Matt Giuca, 2015-07-10 07:52:19]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1228093005/ by mgiuca@chromium.org.

The reason for reverting is: Broke Clang build on Windows according to
http://crbug.com/505319#c30.

Those warnings should be fixed before relanding..

[Matt Giuca, 2015-07-14 03:45:25]

This was re-landed by Nico in https://codereview.chromium.org/1232543005/.