Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1226573002: Clang on Windows: Remove -Wno-unused-variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-unused-variables
Patch Set: Avoid duplicate variables block. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | remoting/remoting_host_win.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 4e7df4aef786c9acfa0d3a1169aa08deb9abfb8b..f589cffe5c02d1863a1614438d4c1166b92cf980 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -808,7 +808,6 @@ if (is_win) {
"-Wno-unused-function", # http://crbug.com/505316
"-Wno-unused-private-field", # http://crbug.com/505317
"-Wno-unused-value", # http://crbug.com/505318
- "-Wno-unused-variable", # http://crbug.com/505319
"-Wno-unused-local-typedef", # http://crbug.com/411648
]
}
@@ -1005,6 +1004,10 @@ config("no_chromium_code") {
# TODO(mgiuca): Move this suppression into individual third-party
# libraries as required. http://crbug.com/505301.
"-Wno-overloaded-virtual",
+
+ # Lots of third-party libraries have unused variables. Instead of
+ # suppressing them individually, we just blanket suppress them here.
+ "-Wno-unused-variable",
]
}
« no previous file with comments | « build/common.gypi ('k') | remoting/remoting_host_win.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698