Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 122653004: depend on fontconfig when building for linux rather than x11 (Closed)

Created:
6 years, 11 months ago by Mostyn Bramley-Moore
Modified:
6 years, 11 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

depend on fontconfig for linux rather than x11 https://codereview.chromium.org/99103006 moved WebFontInfo.cpp from core to platform. In core fontconfig is enabled if OS=="linux", but in platform it is enabled if use_x11==1. In most setups this works because the headers are in the same base directory, but if that's not the case the build will fail. To fix this, I think platform should just depend on fontconfig if OS=="linux". BUG=303332 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/blink_platform.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Mostyn Bramley-Moore
Spang, rjkroege, Stephen: does this change look OK?
6 years, 11 months ago (2014-01-02 11:12:47 UTC) #1
Stephen Chennney
lgtm Good catch. LGTM.
6 years, 11 months ago (2014-01-02 15:21:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/122653004/1
6 years, 11 months ago (2014-01-02 15:21:54 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=17683
6 years, 11 months ago (2014-01-02 19:45:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/122653004/1
6 years, 11 months ago (2014-01-02 21:14:15 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-02 21:14:43 UTC) #6
Message was sent while issue was closed.
Change committed as 164428

Powered by Google App Engine
This is Rietveld 408576698