Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Unified Diff: cc/playback/compositing_display_item.cc

Issue 1226503006: cc: More consistent reasoning about display list memory usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: capacity unit test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/playback/compositing_display_item.cc
diff --git a/cc/playback/compositing_display_item.cc b/cc/playback/compositing_display_item.cc
index 2cd4f4073adc384b54bbc9583276854d585f6b85..31365b5881c22392077744219f114eca52d6c179 100644
--- a/cc/playback/compositing_display_item.cc
+++ b/cc/playback/compositing_display_item.cc
@@ -31,10 +31,9 @@ void CompositingDisplayItem::SetNew(uint8_t alpha,
color_filter_ = cf;
// TODO(pdr): Include color_filter's memory here.
- size_t memory_usage =
- sizeof(float) + sizeof(bool) + sizeof(SkRect) + sizeof(SkXfermode::Mode);
+ size_t external_memory_usage = 0;
DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 1 /* op_count */,
- memory_usage);
+ external_memory_usage);
}
void CompositingDisplayItem::Raster(
@@ -61,7 +60,7 @@ void CompositingDisplayItem::AsValueInto(
EndCompositingDisplayItem::EndCompositingDisplayItem() {
DisplayItem::SetNew(true /* suitable_for_gpu_raster */, 0 /* op_count */,
- 0 /* memory_usage */);
+ 0 /* external_memory_usage */);
}
EndCompositingDisplayItem::~EndCompositingDisplayItem() {

Powered by Google App Engine
This is Rietveld 408576698