cc/debug/rasterize_and_record_benchmark.cc - Issue 1226503006: cc: More consistent reasoning about display list memory usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/debug/rasterize_and_record_benchmark.cc

Issue 1226503006: cc: More consistent reasoning about display list memory usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: capacity unit test Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/debug/rasterize_and_record_benchmark.cc

diff --git a/cc/debug/rasterize_and_record_benchmark.cc b/cc/debug/rasterize_and_record_benchmark.cc

index bed367dd6fee8f7c786881b94cb131a3f5cad2e7..811211d999f890a6f666e2dd84badd4e3e613971 100644

--- a/cc/debug/rasterize_and_record_benchmark.cc

+++ b/cc/debug/rasterize_and_record_benchmark.cc

@@ -223,9 +223,9 @@ void RasterizeAndRecordBenchmark::RunOnDisplayListLayer(

if (memory_used) {

// Verify we are recording the same thing each time.

- DCHECK(memory_used == display_list->PictureMemoryUsage());

+ DCHECK(memory_used == display_list->ApproximateMemoryUsage());

enne (OOO) 2015/07/07 21:12:37 DCHECK_EQ?

jbroman 2015/07/07 21:39:03 Haha, the hazards of modifying an existing line of

} else {

- memory_used = display_list->PictureMemoryUsage();

+ memory_used = display_list->ApproximateMemoryUsage();

}

timer.NextLap();

« no previous file with comments | « cc/base/sidecar_list_container.h ('k') | cc/playback/clip_display_item.cc » ('j') | no next file with comments »